#354 chore: Add status code matcher example Pull request opened by tienvx This matcher can't be used to match the response code unfortunately, because currently

pactffi_response_status

only allow integer status. But it can be useful to match a value in body (like this example), query parameter or header. pact-foundation/pact-php ✅ All checks have passed 26/26 successful checks

#355 fix: arrayContains matcher doesn't work if variants is array with keys Pull request opened by tienvx • On consumer: the example value become

null

• On provider: because example value become

null

, we got this error on verification:

Failures:

1) Verifying a pact between matchersConsumer and matchersProvider Given Get Matchers - A get request to /matchers
    1.1) has a matching body
           $.arrayContaining -> Expected [102.3,"eb375cad-48cc-4f7f-981b-ea4f1af90bf2"] (Array) to be equal to null (Null)

pact-foundation/pact-php ✅ All checks have passed 26/26 successful checks

#356 fix: values matcher doesn't work if values is array with keys Pull request opened by tienvx • On consumer: example values will be array with keys:

'values' => Array (
-        0 => 'a'
-        1 => 'bb'
-        2 => 'ccc'
+        'a' => 'a'
+        'b' => 'bb'
+        'c' => 'ccc'
     )

• On provider: got this error on verification:

Failures:

1) Verifying a pact between matchersConsumer and matchersProvider Given Get Matchers - A get request to /matchers
    1.1) has a matching body
           $.values -> Type mismatch: Expected ["a","bb","ccc"] (Array) to be the same type as {"a":"a","b":"bb","c":"ccc"} (Object)

pact-foundation/pact-php ✅ All checks have passed 26/26 successful checks

#357 feat: Add eachKey matcher Pull request opened by tienvx This is a specification v4's matcher pact-foundation/pact-php Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 20 other checks have passed 20/26 successful checks

#358 feat: Add eachValue matcher Pull request opened by tienvx This is a specification v4's matcher pact-foundation/pact-php ✅ All checks have passed 26/26 successful checks

@Beth (pactflow.io/Pact Broker/pact-ruby) Could we silence GitHub notifications to just notify of releases on this channel as well?

Hey guys, If there is someone who can clarify the flow of testing messages with PHP I would aprrecitate it, asahshasa 👀

@Ruth has left the channel

I would like to self-merge pull requests to

ffi

branch that has 1 approval to speed up development on that branch

Cirrus CI: Failed to start an instance: FAILED_PRECONDITION: Monthly free compute limit exceeded!

@Cody Jenkins has left the channel

#359 revert: Values matcher accept keys again Pull request opened by tienvx Revert #356 I was wrong #356 is a feature, not a bug. • When you pass array without keys to

values

matcher, it compare values using its index (i.e. starting with 0) in the array. • When you pass array with keys to

values

matcher, it compare values using those keys. • Missing keys/indexes are OK. • Additional keys/indexes are NOT OK. • I'm not sure about this behavior. • Pact complain that the value of additional keys/indexes must equals to the first value (e.g.

a

) ??? • Probably because I'm testing this

values

matcher on

Response

? • If using this

values

matcher on

Request

, additional keys/indexes are OK. See this behavior on compatibility suite I'm not really understand the behavior of missing/additional keys/indexes. Look like it's the Postel's law, but in revert? pact-foundation/pact-php ✅ All checks have passed 26/26 successful checks

Hello guys, I want to clarify one point. Can we use the PhpPact\Consumer\Matcher\Matcher inside the content in the

$contents->song

from our ConsumerMessage example? Because I don't know exactly what is the content, I am worried about the schema of the message, like the song attribute.

#360 deps: Update ffi library Pull request opened by tienvx pact-foundation/pact-php ✅ All checks have passed 26/26 successful checks

#361 feat: Support inheritance for body Pull request opened by tienvx This feature is useful for implementing compatibility suite. pact-foundation/pact-php ✅ All checks have passed 26/26 successful checks

#362 feat: Allow capture verifier output Pull request opened by tienvx This change is for implementing compatibility suite pact-foundation/pact-php ✅ All checks have passed 26/26 successful checks

#363 feat: Allow capture mock server mismatches Pull request opened by tienvx pact-foundation/pact-php ✅ All checks have passed 26/26 successful checks

#364 deps: Update ffi library to 0.4.11 Pull request opened by tienvx pact-foundation/pact-php Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 20 other checks have passed 20/26 successful checks

#354 chore: Add status code matcher example Pull request opened by tienvx This matcher can't be used to match the response code unfortunately, because currently

pactffi_response_status

only allow integer status. But it can be useful to match a value in body (like this example), query parameter or header. pact-foundation/pact-php Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 20 other checks have passed 20/26 successful checks

#365 chore: Add generators example Pull request opened by tienvx There is no example for

MockServerURL

yet, because the

url

matcher is not available in pact-php (yet) pact-foundation/pact-php Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 20 other checks have passed 20/26 successful checks

#366 chore: Clean up and use matchers/generators for message example Pull request opened by tienvx

ProcessText

and

ProcessSong

are basically the same test. I combine them, then add matcher + generator into the example. pact-foundation/pact-php Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 20 other checks have passed 20/26 successful checks

#367 feat: Support matchers and generators for message metadata Pull request opened by tienvx pact-foundation/pact-php Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 20 other checks have passed 20/26 successful checks

@Lukasz has left the channel

#368 refactor!: Lazy load binary file Pull request opened by tienvx • This is a breaking change, but only inside

10.0.0-alpha.x

versions • Change c-data from managed to unmanaged pact-foundation/pact-php Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 20 other checks have passed 20/26 successful checks

#369 chore: Rename StringData to BinaryData Pull request opened by tienvx Rename

StringData

to

BinaryData

. This class is only used for binary now. So no need to make it flexible by supporting null-terminated string. pact-foundation/pact-php Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 20 other checks have passed 20/26 successful checks

#370 chore: Use 'Constructor property promotion' PHP 8 feature to make code smaller Pull request opened by tienvx pact-foundation/pact-php Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 20 other checks have passed 20/26 successful checks

#371 FFI > Free unmanaged memory when no longer used Issue created by tienvx There are 2 places that create unmanaged memory: • https://github.com/pact-foundation/pact-php/blob/ffi/src/PhpPact/FFI/Model/ArrayData.php#L44 • https://github.com/pact-foundation/pact-php/blob/ffi/src/PhpPact/FFI/Model/BinaryData.php#L34 There is a potential memory leak if it's not handled. • I already call

FFI::free

for the first one (https://github.com/pact-foundation/pact-php/blob/ffi/src/PhpPact/FFI/Model/ArrayData.php#L58), but I'm not sure it's correctly handled. • I don't know solution for the second one pact-foundation/pact-php

#372 refactor: Create classes for matchers and generators Pull request opened by tienvx Depends on #373, please review it first pact-foundation/pact-php Cirrus CI: linux_arm64 VERSION:8.0 arm_containerphp8.0 Cirrus CI: linux_arm64 VERSION:8.1 arm_containerphp8.1 Cirrus CI: linux_arm64 VERSION:8.2 arm_containerphp8.2 ✅ 23 other checks have passed 23/26 successful checks

#373 chore: Change default datetime format Pull request opened by tienvx • Change the default formats. The previous default formats I copied them from https://github.com/pact-foundation/pact-specification/tree/version-4#supported-generators. I think the new formats make more sense to end-user. • Doing so also fixed a failed test: on this specific day

2023-11-30

, the value become

"2023-12-334T17:15:07"

, not

"2023-11-334T17:15:07"

as expected. I'm not sure what is the problem here. pact-foundation/pact-php GitHub Actions: PHP 8.0 on macos-latest with locked dependencies Cirrus CI: linux_arm64 VERSION:8.0 arm_containerphp8.0 ✅ 24 other checks have passed 24/26 successful checks

#374 feat: Support sync message Pull request opened by tienvx • This is for implementing compatibility suite • Code (mostly) taken from this repository https://github.com/tienvx/pact-php-plugin • In the future I plan to move code from these repositories into this project also: • https://github.com/tienvx/pact-php-csv • https://github.com/tienvx/pact-php-protobuf • https://github.com/tienvx/pact-php-xml • It means most of the code will be in

pact-php

project. Outside of this project will be framework integration e.g. Symfony: • https://github.com/tienvx/pact-messenger-bundle • https://github.com/tienvx/pact-provider-bundle • No test cases at all. This is because I'm not confident with the code structure yet. pact-foundation/pact-php GitHub Actions: PHP 8.2 on windows-latest with locked dependencies GitHub Actions: PHP 8.2 on windows-latest with lowest dependencies GitHub Actions: PHP 8.1 on windows-latest with locked dependencies GitHub Actions: PHP 8.1 on windows-latest with lowest dependencies GitHub Actions: PHP 8.0 on windows-latest with locked dependencies GitHub Actions: PHP 8.0 on windows-latest with lowest dependencies GitHub Actions: PHP 8.2 on macos-latest with locked dependencies GitHub Actions: PHP 8.2 on macos-latest with lowest dependencies GitHub Actions: PHP 8.1 on macos-latest with locked dependencies GitHub Actions: PHP 8.1 on macos-latest with lowest dependencies GitHub Actions: PHP 8.0 on macos-latest with locked dependencies GitHub Actions: PHP 8.0 on macos-latest with lowest dependencies GitHub Actions: PHP 8.2 on ubuntu-latest with locked dependencies GitHub Actions: PHP 8.2 on ubuntu-latest with lowest dependencies GitHub Actions: PHP 8.1 on ubuntu-latest with locked dependencies GitHub Actions: PHP 8.1 on ubuntu-latest with lowest dependencies GitHub Actions: PHP 8.0 on ubuntu-latest with locked dependencies GitHub Actions: PHP 8.0 on ubuntu-latest with lowest dependencies Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary Cirrus CI: Task Summary ✅ 2 other checks have passed 2/26 successful checks