https://pact.io logo
Join Slack
Powered by
If anyone has any bandwidth to get any of the pact...
# pact-php
l
If anyone has any bandwidth to get any of the pact-php branches over the line, I don't know what is the issue with pact-foundation pact-php CI, but the same github yaml works https://github.com/Lewiscowles1986/pact-php/pulls there is a PR to fix a URL, and a separate one to help get an FFI patch through.
m
The URL one looks so basic I just want to merge it, but I think it best the maintainer does that as they own the consequences. It’s possible there is some quantum state causing unreliability, and it just happens to reliably fail on our GH (seems strange, we don’t run custom runners or anything)
FFI might best be Tien
l
It seems to be flaky even on my runners, but it works. I think it must have always been flaky or people get lucky
FFI, that speeds things up, but it uses this URL change anyway.
👍 1
Note: this FFI does less than the original. Mostly because I found some issues with shared objects I thought it cruel to pass on, which were leading to some pipeline failures, which did not mention the missing .so files (running the commands directly did though).
m
Did you re-write it or just tweak what Tien had done? (I’m watching from a far, so am not across the detail). Is it functional? that is, can you use it in your pipelines reliably?
l
Passes all tests is as far as I've got with it, but timing those it saves > 1 minute
🙌 1
m
nice
l
I've also tested on osx, linux and windows now (pet machines local + github)
It should have less failure points. Once FFI handles everything the ruby does it'll be mint (very good)
m
haha yes!
l
(apologies for colloquialisms, multiple conversations, one with someone from north of england)
m
all good. Australian here, mint is a thing (or, at least at some point in my life it was a thing)
l
👍
m
On the Rust integration to PHP, once concern I have is that it’s such a big PR for a maintainer to get and then do anything practically with. It’s an obviously good thing (we want everyone on the FFI) but also, once the code is merged in it’s the maintainer’s job to keep it alive.
👀 1
@Mattermack how do you think we should approach ☝️ ? cc: @Yousaf Nabi (pactflow.io) (something for consideration as we scale)
l
Once the url fix lands, I want to make one more tiny PR to run scheduled weekly builds in PHP pact, but I'm leaving my job soon so will likely leave PHP to rot afterwards.
I definitely have not reviewed the entire FFI PR
👍 1
m
so will likely leave PHP to rot afterwards
😆
😊 1
l
but it will fix the test suites and give future visibility into breakages...
a
Mint. Fellow Manc @Lewis Cowles?
l
Afraid I'm an Essex man, but I've been to Manchester and most places 😉
I was talking to someone from Liverpool at the time
a
Oof, how to turn off a Manc in two sentences 😂
😂 1
👀 1
l
😂
keep your secrets
Open in Slack
PreviousNext
Powered by