<@U0BME18CF7S> please review <https://github.com/O...
# automations-debug
c
@fresh-machine-37269 please review https://github.com/OpenHands/OpenHands/pull/18030 , https://github.com/OpenHands/software-agent-sdk/pull/5532 , https://github.com/OpenHands/OpenHands/pull/18018 18019, 18021, 18022 Feel free to check the screenshots and understand the code. Post reviews, approved or request changes or comment, as you think appropriate.
šŸ‘€ 1
f
šŸ¤– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
āœ… Done! Done — I read through all six PRs (diffs, tests, and the before/after captures) and left a review on each: Approved (all five frontend PRs) • OpenHands#18030 — raw HttpError in profile toasts. Root cause and fix are right;
getApiErrorMessage
now prefers the server's `message`/`detail`/`error`, handles FastAPI validation arrays, and never echoes the raw transport text. Note: plain-text bodies are now dropped to the fallback — a small
typeof body === "string"
branch would keep that copy. Also worth converging the global
query-client-config.ts
toast on the same helper. • OpenHands#18018 — stdio MCP error copy. Correct fix; all three callers pass the tested transport, and the OAuth-as-remote handling is a good catch. Notes: the card's
line-clamp-2
still truncates long details (touch users can't open the tooltip),
MCP$TEST_ERROR_TIMEOUT
still says "Check the URL" for stdio, and the reworded key touches all 15 locales. • OpenHands#18019 — LLM profile menu keyboard. Both root causes verified (empty first commit on the portaled menu; arrow nav over a disabled item). Follow-up worth filing:
agent-profile-actions-menu.tsx
and
meta-profile-actions-menu.tsx
are drifted copies with the identical bug and weren't touched. • OpenHands#18021 — download failure + Recent preset. Both fixes are sound. Notes: the toast still ends in the raw
HTTP request failed (502…)
text (the new helper from #18030 would clean that up), and the old Recent preset had
showOlderConversations: false
while the new one is the full default, so persisted users will read "Custom" until they re-click. • OpenHands#18022 — automation run logs. Diagnosis and the real-client/real-
fetch
regression test are solid; cloud paths pinned. One assumption to confirm: local
resolveHost
now always uses the backend host, so the single-host invariant is worth stating explicitly. software-agent-sdk#5532 — already approved by the bot at the current head; the
exclude: ^.pr/
change is minimal and correctly scoped, so no second review from me. The only red check anywhere is a stale "Validate PR description" run from an earlier commit; every current head is green.