< fresh machine 37269> Please review 18009 18011 18012 18013 OpenHands #automations-debug

<@U0BME18CF7S> Please review 18009, 18011, 18012, ...

calm-artist-7206

10/05/2026, 11:22 PM

@fresh-machine-37269 Please review 18009, 18011, 18012, 18013, 18014, 18015, 18016, 18017 from openhands repo. Feel free to look at the screenshots in their descriptions and check the code as you see fit. Post as review with event approved if you think we can merge, request changes if not, or comment if you see fit.

👀 1

fresh-machine-37269

10/05/2026, 11:22 PM

🤖 On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…

fresh-machine-37269

10/05/2026, 11:40 PM

✅ Done! All eight reviews are posted. Here's where things landed: Approved (4) • #18009 — null batch entry → "not found": correct and minimal; 123 tests pass at head; all callers already handle

null

. ✅ • #18011 — Delete-automation confirmation as a real

ModalBackdrop

dialog: Escape/focus/`role=dialog` all verified, 35 tests pass. ✅ • #18013 — Model Router text

text-white

→ `text-contrast`: computed-color evidence shows it fixes Light+ without touching dark themes. ✅ • #18015 — overflow menu

useClickOutsideElement

ignore-ref: real regression tests replay the browser's click order; 19 pass. ✅ Commented (3) — code is sound, but not mergeable yet • #18014, #18016, #18017 all fail the required Validate PR description
gate: the

HUMAN:

section is still the untouched template ("Add a short human-written note between

HUMAN:

and `AGENT:`"). Per

AGENTS.md

I don't edit that section, so I left it to a human. Each review documents the code findings: #18014 and #18016 are correct fixes (I traced the draft-restore and message-target flows); #18017's name-follow logic is wired correctly with no stale-closure issue. Two of them are also still marked as draft. #18012 was already merged before I got to it, so I left it alone. One non-blocking note worth a follow-up: in #18016 the

recommended-automations-launcher

still queues its prompt with the default

"conversation"

target while navigating to Home, so that launch won't prefill the Home composer (same as before this PR — not a regression).

calm-artist-7206

10/05/2026, 11:48 PM

@fresh-machine-37269 Great, thank you! take a look again at those three you left with comment and approve if fixed per your note.

👀 1

fresh-machine-37269

10/05/2026, 11:49 PM

✅ Done! All three are now approved. ✅ The blocker on each was purely the description gate — the

HUMAN:

sections now have real notes,

Validate PR description

passes at each head, and the head commits are unchanged, so my code review stands.

test-and-build (ubuntu)

and

(windows)

are green and all three branches are mergeable. • #18014 — Branch from here: fork draft seeded before navigation. ✅ • #18016 — Use skill / Create Automation prefill Home. ✅ (the

recommended-automations-launcher

target note stays a non-blocking follow-up) • #18017 — Auto-filled profile name follows the model. ✅ That completes all eight: 18009, 18011, 18012 (already merged), 18013, 18014, 18015, 18016, 18017 are approved; none remain with a comment.

Open in Slack

Previous Next