<@U0BME18CF7S> please review openhands/openhands P...
# automations-debug
c
@fresh-machine-37269 please review openhands/openhands PRs from 18023-18028 . Feel free to check the screenshots and understand the code. Post review on each, approved or request changes or comment, as you think appropriate.
šŸ‘€ 1
f
šŸ¤– On it! View progress here: oss-agent-canvas.ngrok.dev/conversations/…
āœ… Done! Done — reviewed all six and posted my verdict on each: • #18023 (unknown URLs → in-app not-found) — āœ… Approved. Catch-all route inside the root layout is the right fix and also kills the React #418 hydration error. • #18024 (Manage backends → redirect off detail pages) — āœ… Approved. Good refactor into `useBackendSwitchRedirect`; left a non-blocking DRY note that
backend-selector.tsx
could share the same hook. • #18025 (single, accurate install/update errors) — šŸ’¬ Commented. Behavior and tests look solid; flagged one thing to confirm before merge —
getApiErrorMessage
now prefers
exception
over
detail
unconditionally, which could surface technical strings if a server ever sends both. • #18026 (keep Automations filters popover open) — āœ… Approved.
composedPath()
is the correct root-cause fix, with a good
flushSync
regression test and Playwright guard. • #18027 (Model Router / Agent Context in command menu; Ctrl+K off Apple) — āœ… Approved. The nav-invariant test is the standout. Left a cosmetic nit that the
uppercase
class renders
Ctrl+K
as
CTRL+K
. • #18028 (conversation header menu clamp + Escape) — āœ… Approved. Clamp, Escape-close-with-focus-return, and class scoping are all correct. CI is green on all six (the only "failure" is an old, superseded
Validate PR description
run — the latest one passed). I checked the
.pr/
before/after screenshots and console captures as context; note those directories get auto-removed once a PR is approved.