First release for #C084HP11VPF. 142 files. Happy to trade https://github.com/nf-core/proteinannotator/pull/71

Can trade for my 45 #C062H82UCRG but can't get to yours until next week if that is a problem

No problem at all

Just so it is also in this thread, I will also review

Niklas: https://github.com/nf-core/proteinannotator/pull/72 the PR fixing the points you raised

Ok, I'll take a look tomorrow

Thanks 😄

@Evangelos Karatzas reviewed! Just that one test failure to debug Otherwise I' made your suggestionso n #C062H82UCRG release, and suggested a change I want your OK on vefore I commit: https://github.com/nf-core/createtaxdb/pull/147#discussion_r2781470002

Tis good! Thanks for the review :D

To avoid discussing this via github: > statistics of input protein fasta files and identifies protein annotations such as conserved domains, functions and secondary structure features, based on their sequence data. I am being pendantic here, but I think it is important to remain accurate: An annotation is not an intrinsic aspect of a sequence. An annotation is something we create, based on something we think (or predict) the sequence does, but it remains an annotation. My view is that sequences have certain features which may be intrinsic to the sequence (such as forming a helix in a cellular context), but what we create are annotations, which may or may not correspond to a real feature

I see what you mean..you are right...so would "predict" still be the most accurate option here?

I think you always "create" annotations based on "predicted" features?

I am updating to this:

nf-core/proteinannotator is a bioinformatics pipeline that computes statistics for protein FASTA inputs and produces protein annotations based on predicted sequence features, including conserved domains, functions, and secondary structure.

The suggestion works

Pushed, let me know if the PR's ok!

Uhh for this one, https://github.com/nf-core/proteinannotator/pull/74/changes#diff-74d172a2ad8b764105f3bd0266eaa39fe59648ae35c0a893318fad3946285d0f (the structure) I meant putting ath across for every channel input in all your subworkflows