I have one PR against `dev` which is massive, and ...
# release-review-trading
n
I have one PR against
dev
which is massive, and essentially a new release. How does the protocol work, do I need to find people willing to review the huge PR, and then more people to review the release PR, or can this be done in one go?
j
What is huge? But generally if the PR to dev is identical to what will be the dev to main/master, the people who review the first one can just give a 'perfunctory' approval on the second once changes to the first are made to their satisfaction
n
https://github.com/nf-core/genomeassembler/pull/171 this huge. Ok that seems reasonable, thanks
j
Ah that's reasonable 😉
I assume about 50% are modules updates?
n
Hm, probably not
I refactored the whole thing
but sure, module updates probably contribute
j
Regarldess, 234 isn't the worst I've seen
n
Yeah, sure, number of files is probably largely stuff that has been reviewed upstream
👍 1
For me the thing that takes effort with reviews is not so much checking "viewed" on files that others looked at before, but figuring out whats going on the workflow 😄
j
Fair enough!