Hi, the github ci linting currently fails. Since ...
# tools
k
Hi, the github ci linting currently fails. Since it detects some "merge markers" - however those are part of bam entries in snapshots... not sure how to resolve it in a smart way. See here: github.com/nf-core/…/85818123977?pr=523
👀 1
m
I would say just not include the tests files coming from the modules repo
j
I had to work around this too- I think there are at least one or two modules that should make better use of snapshot() so we don't store literal output content in the .snap files. github.com/nf-core/riboseq/pull/194#…
👍 1
m
We don't run the tests from modules in the pipelines, so I just don't commit them. But yeah making a better snap is also a solution
👍 1
k
Just realized, I think I was adding the bam output in the snapshot, got asked during review to use the bam plugin 😄 I put it on my to do to update the bowtie2 testing strategy and go with Johnathan's solution for now.