I'm getting 3 strict syntax warnings from unedited template files. AITA?

Warn  subworkflows/nf-core/utils_nextflow_pipeline/main.nf:43:5: Emit name should be omitted when there is only one emit
│  43 |     dummy_emit = true
╰     |     ^^^^^^^^^^^^^^^

Warn  subworkflows/nf-core/utils_nfcore_pipeline/main.nf:20:5: Emit name should be omitted when there is only one emit
│  20 |     valid_config = valid_config
╰     |     ^^^^^^^^^^^^^^^^^^^^^^^^^

Warn  subworkflows/nf-core/utils_nfschema_plugin/main.nf:72:5: Emit name should be omitted when there is only one emit
│  72 |     dummy_emit = true
╰     |     ^^^^^^^^^^^^^^^

It's bugging me because this is all that's left to get a clean lint in #C06R4FC4C1E

I do not like that we are enforced to have no name when only one emit

Kind of same, but that doesn't change how the linter works

it's just a warning

Does the strict syntax tracker care about warnings?

No idea

I've checked, the main plot only checks for errors, but there is a separate one for warnings. Only a few pipelines are warning-free, presumably due to the above. By the way, is there a reason for the dummy emits to exist?

I honestly don't remember this one

The

dummy_emit = true

in

subworkflows/nf-core/utils_nextflow_pipeline/main.nf

and

subworkflows/nf-core/utils_nfschema_plugin/main.nf

date from 2024 !

Yes you can simply remove them here to prevent the error, the emit is used nowhere and was need to prevent some bug in Nextflow from a couple years ago

valid_config

from

UTILS_NFCORE_PIPELINE

is also not used anywhere else in the template, so it could perhaps be removed (since the

checkConfigProvided

function logs a warning if it's invalid)

oh, so we still have this issue

After way too much fighting with git branches: github.com/nf-core/modules/pull/12329