https://nf-co.re logo
Join Slack
Powered by
<@UE4L64T4G> is it OK to deprecate 'custom calcula...
# multiqc
j
@Phil Ewels is it OK to deprecate 'custom calculated' values from a module if it makes nonsense output? @Sofia Stamouli and I just identified that if you run FastQC on nanopore data, custom statistics the MultiQC module makes generates crazy values that do not correspond to anything Basically this line: https://github.com/MultiQC/MultiQC/blob/00d7f33df8cec2be307454119b2a8714e33a94f9/multiqc/modules/fastqc/fastqc.py#L417-L435 Where we think
# is within that range. Probably good enough though.
Actually is not good enough and is generating very misleading output 😅
😆 1
p
#overlyhonestcodecomments
100 rainbow 2
j
Sofia is making an issue
No it wasn't you, it's oooooooooold
p
In fact I asked for it to be reported upstream: https://github.com/MultiQC/MultiQC/pull/1745/changes#r1049840721
Looks like he never added the issue though 😞
this 1
j
Doesn't look like they made it...
p
I think Simon is gearing up to a new release with a bunch of my PRs merged
👀 2
Maybe we can try to get this in as well
cattyping 1
j
OK!
If you have already got a lot of good will, would you mind making the issue?
p
on it
j
❤️
p
Working on a PR now
j
❤️
7 Views
Open in Slack
PreviousNext
Powered by