Hello, I am running into some linting issues in my...
# nostupidquestions
j
Hello, I am running into some linting issues in my PR #10584 which addresses topic module migration for canu We decided we had to hard-code the version since
canu -version
returns a build hash rather than a clean version; implement as
tuple val("${task.process}"), val('canu'), val("2.3"), emit: versions_canu, topic: versions
In the meta.yml this is then represented as
Copy code
versions_canu:
    - - ${task.process}:
          type: string
          description: The name of the process
      - canu:
          type: string
          description: The name of the tool
      - "'2.3'":
          type: string
          description: The expression to obtain the version of the tool
and this passes linting locally but fails in github CI... Next trying
nf-core modules lint canu --fix
adds another block to the yml that looks like
Copy code
- "'2.3'":
          type: string
          description: The expression to obtain the version of the tool
        "2.3":
          type: string
          description: The expression to obtain the version of the tool
But this does not pass linting and creates a duplicate description of version Any idea how to get this to pass lint in the PR?
m
we use the dev version of nf-core/tools in the modules CI, so be sure to always have the latest version installed (
pip install --upgrade --force-reinstall git+<https://github.com/nf-core/tools.git@dev>
) I think your fix is that it should be
"2.3"
instead of
"'2.3'"
in the meta.yml
t
Unrelated to your error, the file with all of the versions should show exactly which version was used (for reproducibility/auditing), so I think it would make sense to retain the build hash as (part of) the version designation. If you want to add something more "human readable" in addition to that, that's fine, but I would not replace it.