Please remind me - do all PRs need a review from t...
# nostupidquestionsu
Uri David Akavia
03/12/2026, 5:06 PMPlease remind me - do all PRs need a review from the maintainer/core team? I'm asking because I reviewed a PR, and I think that's the case - I can't approve it, only core/maintainer/?? can. Is this correct?
s
Simon Pearce
03/12/2026, 5:15 PMYou can review PRs
Simon Pearce
03/12/2026, 5:15 PMAnd approve them
Simon Pearce
03/12/2026, 5:16 PMIf you aren't confident, then don't
Simon Pearce
03/12/2026, 5:16 PMbut we don't have a rule that says you have to be a core/maintainer to approve
u
Uri David Akavia
03/12/2026, 5:17 PMOkay, thank you.
s
Simon Pearce
03/12/2026, 5:17 PMBut especially simple things like the topics migration are straightforward (check the version is correct, complain if the regex to get the version is too complicated, ensure they remove the versions.yml)
3 Views