https://linen.dev logo
Powered by
# haxe-ui
  • b
    it may work, but doesnt mean its correct - "style" may get overwritten by style sheets - customStyle is applied after styles are built
  • b
    its working with customStyle
  • b
    its defo bad naming on my part... style is what most people would use instinctively, but really its the "internal" style of the component (ie, the computed style)
  • b
    you can just use 
    internalStyle
  • b
    its more straight forward the 
    computedStyle
  • b
    computedStyle
    makes more sense... might make it private too
  • b
    dont make it private, it still has useful stats
  • b
    like the default style of the object
  • b
    true - im on the fence about making it private
  • b
    i think things should be made private if theres no use for them outside of the class
  • b
    but if theres a use for it it shouldnt be private
  • b
    the issue is i dont want people to use computedStyle
  • b
    AHM textfield's TextEngine why are u private
  • b
    they wont, its to scary to mess with something that has 
    engine
    , 
    computed
    or 
    internal
    in its name
  • b
    doing 
    myComponent.computedStyle.color = ...
    doesnt make sense, and may work, but thats an accident
  • b
    compiled
    too
  • b
    true enough
  • b
    internal
    is kinda known too, thats why i prefer it
  • b
    (_internal folder)
  • b
    internalStyle also makes sense, and is good naming... so i might use it... not sure... the point really is to name it something other than "style" which is just wrong as you have discovered
  • b
    its use to hide/discourage users to mess with stuff, so its a good fit
  • b
    you can also have a warning in the docs
  • b
    ive even been caught by it myself before... muscle memory
  • b
    > the docs šŸ˜„
  • b
    i add them all the time if i dont want users to do weird stuff
  • b
    tbh i dont mind making the docs myself when im more experienced with haxeui
  • b
    i like writing docs and people like it when there are docs
  • b
    i hate writing docs (or reading them generally - ideally the source), but yeah, people like docs
  • b
    thats how i learned to code why?
  • b
    yeah, im not knocking it... i just quite rarely read docs, even in C++ / Java (work stuff)... i tend to end up reading source or decompiling the java (intellij is great at that)
1...967968969...1687Latest