Haxe

... ... this could go on for a while... heh heh

refactoring haxeui macro code... ... what a difference! old:

heh heh, wont let me paste the old code... ... too big! 😄

```
        if (builder.hasSuperClass("haxe.ui.core.Component") == false) {
            return "Must have a superclass of haxe.ui.core.Component";
        }
        
        if (builder.constructor == null) {
            return "A class building component must have a constructor";
        }

        ModuleMacros.populateClassMap();
        
        var xml = builder.getClassMetaValue("xml");
        var namedComponents:Map<String, String> = new Map<String, String>();
        var expr = ComponentMacros.buildComponentFromString([], xml, namedComponents);
        var codeBuilder = new CodeBuilder(expr);
        codeBuilder.add(macro
            addComponent(c0)
        );
        
        var createChildrenFn = builder.findFunction("createChildren");
        if (createChildrenFn == null) {
            createChildrenFn = builder.addFunction("createChildren", macro {
                super.createChildren();
            }, [APrivate, AOverride]);
        }
        createChildrenFn.add(codeBuilder);
        
        for (id in namedComponents.keys()) {
            var safeId:String = StringUtil.capitalizeHyphens(id);
            var cls:String = namedComponents.get(id);
            builder.addVar(safeId, TypeTools.toComplexType(Context.getType(cls)));
            builder.constructor.add(macro
                $i{safeId} = findComponent($v{id}, $p{cls.split(".")}, true)
            , 1);
        }
        
        return null;    
```

```
createChildrenFn = builder.addFunction("createChildren", macro {
    super.createChildren();
}, [APrivate, AOverride]);
```

^looks like that might be nicer with a `macro class`?

if the function doesnt exist, create it, then add to it, if it does exist then use that, and add to it

hm.. maybe I misunderstand the code, but it just seems like an awkward way to create a function with macros

with macro classes, you can use regular Haxe syntax to declare fields

```
var createChildrenFn = (macro class {
    override private function createChildren() {
        super.createChildren();
    }
}).fields[0];
```

I've talked a bit about that here https://stackoverflow.com/questions/48475603/using-haxe-macros-to-instantiate-a-class-with-parameters/48475928#48475928

<@385014891750096896> you probably want to use tink_macro's ClassBuilder https://github.com/haxetink/tink_macro#classbuilder