https://linen.dev logo
Powered by
# haxe-ui
  • b
    hmmm, fair enough... must be something else, no idea what it could be though as there is nothing special really about dialogs in composite backends
  • b
    ill have a play tomorrow
  • b
    > (i have no idea where to find trace output in android studio) logcat
  • m
    I'm having a hard time debugging this:
    Copy code
    C:/HaxeToolkit/haxe/lib/haxeui-core/git/haxe/ui/macros/ComponentMacros.hx:247: characters 51-66 : Not enough arguments, expected onClicked:(entity.ui.lobby.item.ItemSlot, model.Item) -> Void
  • m
    I'm not sure how I messed up haxeui's macros
  • m
    Obviously I did not tinker with them directly... It's the side effect of something that I can't identify
  • m
    It seems to happen when using a custom component, not sure though
  • m
    Any idea on how to track this down?
  • m
    Custom components are defined like this:
    Copy code
    xml
<module>
    <components>
        <component file="assets/haxeui/xml/lobby/item/description/item_description_box.xml" class="entity.ui.lobby.item.description.ItemDescriptionBox" alias="ItemDescritionBox" />
        <component file="assets/haxeui/xml/lobby/item/item_slot.xml" class="entity.ui.lobby.item.ItemSlot" alias="ItemSlot" />
    </components>
</module>
  • m
    usage is like this:
    Copy code
    xml
<item-slot horizontalAlign="center" />
  • m
    If I remove this 👆 line from the xml, everything works fine
  • b
    constructor args?
  • b
    @User
  • m
    Yeah... completely forgot about them....
  • m
    Custom components can't have constructor args right?
  • m
    The macro error message is not the clearest, but it must be it
  • b
    they can but there is a kinda of macro type hack to make it work(ish)... but ideally, no components (custom or otherwise) should have constructor args... 1) it makes initializing them in xml a problem / impossible and 2) it kinda indicates your component is in need of an initial state, which in haxeui could go wrong depending on your backend
  • b
    (mainly its the xml thing though)
  • m
    I think I ended up hitting this because ItemSlot was actually not a custom component, I was creating it by code.
  • m
    The need for inserting it directly into xml came afterwards
  • m
    But it's a trivial refactor so no probs
  • b
    yeah, i mean, you could give your components default constructor args... then things will probably be fine... but i would argue then your component would be better having getters / setters
  • b
    basically, if something is important enough to be a constructor arg, i would argue its important for it to be a getter / setter too (if its a component, i dont mean in general)
  • b
    out of interest, what are you / were you passing in as a constructor arg?
  • m
    A click callback that has parameters
  • m
    Copy code
    haxe
ItemSlot -> Item -> Void
  • m
    It only reacts to this callback if an item has been set
  • b
    right, sounds like a good candidate for a custom event
  • m
    Copy code
    haxe
onClick = e ->
{
   if(_item != null)
   {
      onClicked(this, _item);
   }
}
  • b
    on dont really get that tbh... why not just use the actual on click? Isnt that duplication?
1...627628629...1687Latest