https://linen.dev logo
Join Discord
Powered by
# haxe-ui
  • a
    huh, yeah, that's an interesting problem
  • a
    could add a whitelist feature
  • a
    if the whitelist exists, just use that otherwise traverse everything
  • b
    whitelist isnt the what to go... blacklist is
  • a
    as in user definable
  • a
    default is blacklist
  • b
    4 years down the line there will be a module "my-module" and it wont work, and no one will remember why
  • b
    well, the user can just create a classpath.exclusions, no? I mean, i guess i could add a classpath.inclusions, but i dont see the need personally
  • b
    the only reasons the exclusion file exists in the backends is because there are some general assumptions and exclusions that can be made at that level, the rest is up to the user really
  • a
    I don't know how much of an impact this search has on completion, but, an inclusion list would allow the user to narrow the scope to their search space
  • b
    the impact on completion is huge... as you might remember, i think you went from 2000-3000ms to like 50 or 100
  • a
    yeah, but i mean, could that 50 be brought down to 25 or something with a "only search my 
    /src/components
    and 
    /haxeui/components
    dirs"
  • b
    probably, but i think you can also do that with an exclusion file, cant you? Its not like you have to list 1000s of items to exclude
  • a
    I'm not sure, tbh, I don't know how wide the search space is with the blacklist
  • b
    regex... so 
    \/ecs\/
    for example
  • a
    oh, you have to read the file as well don't you?
  • b
    assuming this will exclude anything with "/ecs/"
  • a
    yeah, i suspect a whitespace option would be useful 🤔
  • a
    for completion anyway
  • b
    i mean, ill consider it, but it just seems like another moving part for no real benefit...
  • b
    add three items in an inclusion file, or adding three items in an exclusion file...
  • a
    completion speed is beneficial 😢
  • b
    yeah, but you have the ability to exclude now
  • a
    maybe i'm missing info
  • b
    its the same thing, in reverse... "only allow these classpaths" (this is whitelist - doesnt exist), "allow any classpath but these" (blacklist - this exists now)... the can do the same thing
  • a
    but the naunce is search everything except 
    x
    vs search only 
    x
    I'm not sure how big "everything" is in a "normal" situation, but, it can be unnecessary, like with the kha setup
  • b
    this is the classpath.exclusions for kha:
    Copy code
    ; speeds up build
Kha\/Sources\/
Kha\/Backends\/
Kha\/Tools\/
  • b
    not exactly big
  • a
    right, but, should it even need to search 
    /Kha/
    at all?
  • b
    thats done on purpose incase there is a lib that is "/kha/" for some reason... im just playing it safe
1...143314341435...1687Latest