https://linen.dev logo
Join Discord
Powered by
# haxe-ui
  • w

    witty-island-52596

    09/22/2022, 6:02 PM
    thanks
  • w

    witty-island-52596

    09/22/2022, 6:30 PM
    @bright-gpu-74537 https://github.com/haxeui/haxeui-flixel/blob/master/haxe/ui/backend/ComponentImpl.hx#L46
  • w

    witty-island-52596

    09/22/2022, 6:30 PM
    I was able to fix it by setting it back to false at the bottom of the constructor
  • w

    witty-island-52596

    09/22/2022, 6:31 PM
    but i don't know if there are unintended side-effects of doing that
  • b

    bright-gpu-74537

    09/22/2022, 6:41 PM
    oh... lol... i have no idea why that is there...
  • b

    bright-gpu-74537

    09/22/2022, 6:41 PM
    ill look at git blame
  • w

    witty-island-52596

    09/22/2022, 7:07 PM
    lol, been there
  • b

    bright-gpu-74537

    09/22/2022, 7:07 PM
    yeah, i get the feeling that actually that property is a "test" or something that i left in (by mistake)
  • b

    bright-gpu-74537

    09/22/2022, 7:08 PM
    because i dont know what it actually does, so i cant see how i used it effectively for anything
  • b

    bright-gpu-74537

    09/22/2022, 7:08 PM
    my guess is i tried it for "something" and didnt take it out
  • b

    bright-gpu-74537

    09/22/2022, 7:08 PM
    ill run some tests just to make sure it doesnt break anything, but i doubt it will - nice find... should have noticed that much sooner!
  • w

    witty-island-52596

    09/22/2022, 7:09 PM
    counterpoint, it would make sense that you meant to set it true and then false to prevent performing the same visible and scrollfactor operations on all members
  • w

    witty-island-52596

    09/22/2022, 7:10 PM
    I assume this code will also execute on all it's members at some point since it seems like most things in haxeui-flixel are FlxSpriteGroups
  • b

    bright-gpu-74537

    09/22/2022, 7:11 PM
    it could be that, but maybe as just a dirty optimisation rather than an actual issue i was facing
  • b

    bright-gpu-74537

    09/22/2022, 7:11 PM
    but either way, it seems like it shouldnt have been there in the first place
  • b

    bright-gpu-74537

    09/22/2022, 7:11 PM
    esp. if its breaking things
  • b

    bright-gpu-74537

    09/22/2022, 7:11 PM
    (which it is)
  • w

    witty-island-52596

    09/22/2022, 7:13 PM
    yeah not sure if (potentially premature) optimization is worth unknown behavior
  • w

    witty-island-52596

    09/22/2022, 7:13 PM
    ill close my pr
  • b

    bright-gpu-74537

    09/22/2022, 7:13 PM
    yeah, cool - thanks though... ill run some sanity tests just to make sure its not something else (i dont think it is)...
  • w

    witty-island-52596

    09/22/2022, 7:14 PM
    when you fix, try to link the HF issue so I know to close it
  • w

    witty-island-52596

    09/22/2022, 7:14 PM
    or just close it
  • b

    bright-gpu-74537

    09/22/2022, 7:14 PM
    yeah, will do
  • w

    witty-island-52596

    09/22/2022, 9:49 PM
    turns out the mac issue is happening because my mac's dpi is double that of my windows laptop
  • w

    witty-island-52596

    09/22/2022, 9:50 PM
    192 and 96 respectively
  • w

    witty-island-52596

    09/22/2022, 9:52 PM
    looks fine when I set Toolkit.scaleX/Y to 1, 1
  • i

    icy-zebra-52882

    09/22/2022, 9:58 PM
    doesn't mac use 72 as the "base" DPI rather than Windows' 96?
  • w

    witty-island-52596

    09/22/2022, 10:03 PM
    my mac is definitely higher dpi than my win
  • w

    witty-island-52596

    09/22/2022, 10:04 PM
    whenever I look at mac screenshots on windows their massive
  • w

    witty-island-52596

    09/22/2022, 10:06 PM
    > - 2021 16-inch MacBook Pro - 3456 x 2234 at 254ppi > - 2021 14-inch MacBook Pro - 3024 x 1964 at 254ppi > - 2019 16-inch MacBook Pro - 3072 x 1920 at 226ppi > - 2012 15-inch MacBook Pro - 2880 x 1800 at 220ppi > - 2012 13-inch MacBook Pro - 2560 x 1600 at 227ppi
1...127212731274...1687Latest