# ceramic
- a
ambitious-knife-25690
03/04/2023, 9:44 AMI can't recall why I have this in handleAddComponent - b
bright-gpu-74537
03/04/2023, 9:44 AMremove it and see if its all the same, you shouldnt need to check anything like that tbh - b
bright-gpu-74537
03/04/2023, 9:45 AMadd a component to the "screen" and its the root, handleAddComponent is called on a component, so by definition you know its parent (ie, the instance where its called) - b
bright-gpu-74537
03/04/2023, 9:46 AMCopy codehaxe private override function handleAddComponent(child:Component):Component { // "this" is the parent component return child; } - a
ambitious-knife-25690
03/04/2023, 9:48 AMcurrent test case is a basic switch atm because I think if I fix the switch a lot of my other issues get fixed as well - a
ambitious-knife-25690
03/04/2023, 9:48 AMwonder if this is related 🤔 - b
bright-gpu-74537
03/04/2023, 9:49 AMis the GH repo up to date? - b
bright-gpu-74537
03/04/2023, 9:49 AM(so i can read it) - a
ambitious-knife-25690
03/04/2023, 9:50 AMpretty much yeah - a
ambitious-knife-25690
03/04/2023, 9:50 AMit is the best version i have atm - a
ambitious-knife-25690
03/04/2023, 9:50 AMall my local changes are experiments trying to solve annoying bugs - b
bright-gpu-74537
03/04/2023, 9:50 AMCopy code
this defo seems un-neededhaxe if (this.parentComponent == null && !this.addedRoot) { App.app.scenes.main.add(this.visual); this.addedRoot = true; } - a
ambitious-knife-25690
03/04/2023, 9:51 AMi just tested with notifications and removing it seems to have no effect - b
bright-gpu-74537
03/04/2023, 9:51 AMi dont think it ever runs because i dont think parentComponent is (or can be) null in that call - a
ambitious-knife-25690
03/04/2023, 9:52 AMoh it defo runs - a
ambitious-knife-25690
03/04/2023, 9:52 AM2 secs - b
bright-gpu-74537
03/04/2023, 9:52 AMok, so maybe parentComponent is set after that call... but either way, you shouldnt need to have that check / special logic - b
bright-gpu-74537
03/04/2023, 9:53 AMoh, sorry "this.parentComponent"... gotcha - a
ambitious-knife-25690
03/04/2023, 9:53 AMahhh, maybe that's why i thought i needed at one time - b
bright-gpu-74537
03/04/2023, 9:53 AMeither way... i dont think you should have it - b
bright-gpu-74537
03/04/2023, 9:53 AMthis.parentComponent can be null... i thought "child.parentComponent" for some reason - a
ambitious-knife-25690
03/04/2023, 9:53 AMi do have to use pcomponent in some places and if it is null it causes crashes - b
bright-gpu-74537
03/04/2023, 9:55 AMa root component can have a null parentComponent... but the child cant... so i misunderstood... anyways, its irrelevant, i dont see why you need to add the component to the "scene" when adding a child to it - a
ambitious-knife-25690
03/04/2023, 9:55 AMi think you're right - a
ambitious-knife-25690
03/04/2023, 9:55 AMi've tried on 2/3 test cases and I have no issues - a
ambitious-knife-25690
03/04/2023, 9:56 AMmaybe I changed multiple things at one point and miscorrelated this as being relevant 😂 - b
bright-gpu-74537
03/04/2023, 9:56 AMyeah, likely... probably there from the start before you did the screen thing or something - a
ambitious-knife-25690
03/04/2023, 9:57 AMyeah, i'll keep it out for now and keep it in mind - a
ambitious-knife-25690
03/04/2023, 9:57 AMdoesn't seem to have an obvious negative effect - a
ambitious-knife-25690
03/04/2023, 9:58 AMthanks!