Hello! I'm trying to enable commit signing and it ...
# how-do-i
s
Hello! I'm trying to enable commit signing and it doesn't seem to be working. I've tried using the github-provided public email, as well as making all my github emails public and using the primary one too. Is it supposed to take some time to actually register as being enabled, or should it be instant?
🎫 1
p
(If applicable) To help us more clearly understand what you're trying to do, please provide additional details about: - Screenshots / debug logs / list of commands you've tried to run so far - Your workflow - Current state
did you also set this up on graphite? docs ref what is the issue youre seeing? specific error or?
s
I've done this and added it to github and nothing is happening. Not sure if this page is supposed to update with "success" or something? But when I go to merge other prs in it still says I need to enable this and takes me back to this page
I'm basically just stuck at this point 😞
🎫 1
p
okay few things to check here: • In GitHub, look at an existing commit that Graphite says is “not signed” and confirm the author/committer email on that commit. • Make sure that email matches the UID/email on the GPG key they uploaded. also you said nothing is happening, just to confirm yo upasted the entire thing including the
-- begin...
? Once the key is added to GitHub, any newly created signed commits should show as Verified right away. It generally will not “retroactively” flip existing commits. Could you share a graphite link this is happening on?
s
I have the gpg key added correctly and I can confirm that it is being used to verify commits from graphite when rebases happen. But for whatever reason I'm still getting the "commit signing required to merge" message. All I want to do is be able to click the "merge" button from a dependabot PR through graphite
🎫 1
p
Thanks for the extra color here Sammy i think the issue is we check that the author of the PR has commit signing enabled and since the author is "dependabot", not the user, that will always be false. Unfortunately we dont have handling for this today.
👍 1
s
Do you have a timeline for when that might be fixed? The majority of PRs for us are dependabot PRs at the moment, and having to go back to the github UI to handle them is the sort of thing graphite is supposed to prevent 😞
p
I do not have a timeline for this unfortunately. To set some expectations this is not something we are actively working on.
😞 1