I have a downstack PR (1/2) that's ready to merge ...
# report-bugs
s
I have a downstack PR (1/2) that's ready to merge according to github. There's a file change that's marked as belonging to a team using
CODEOWNERS
file. I'm part of that team. GitHub lets me merge it without needing extra approvals but on Graphite, I'm seeing "Needs approvals from file owners" pointing to this specific file on sidebar. Is this a bug or is Graphite doing this correctly? Follow-up: I don't see an option to override and merge even though I have those permissions in GitHub. Is this not possible to do from Graphite side?
p
(If applicable) To help us repro, please send the following if you haven't already: - PR links, screenshots, and/or debug output if applicable - Repro steps - Does this happen consistently? Just to you or others on your team also? - Is this a regression? Is the problem new? - If you're having an issue with the CLI, please send us debug logs using
gt feedback --with-debug-context <any message>
Hey Sangeeth, i THINK this is beacause you have a branch protection rule that we are interpreting as completely block even if admin which i dont believe github enforces the same way (they allow admin bypass here)
👀 1
s
we have that disabled right now for this repo. we have the following org ruleset configured also, could this be related?
p
Yes it could be an issue as well, do you have graphtie as bypass permissions? is this an enterprise ruleset?
s
we have gh enterprise but afaik, nothing configured at that level. can check again in the morning. i noticed we had branch protection rules AND rulesets at repo level and then at org level. Cleared the repo-level stuff so will check again to see if that has any effect. We don't have Graphite app in the bypass list for the org ruleset that contains the pull request related rules I shared earlier — should it be added?
Issue persists btw, can DM the URL of the PR if it helps.
in this case, the approver is part of the CODEOWNERS
@team
for these files but still saw this blocker. github side once again looks fine. we're hitting some weird edge case here maybe? i wouldn't mind this if I could override and merge but that option is also missing I think.
p
Hi Sangeeth, i misrread your last note... be clear, i think youll need to clear org level rulesets and redo at the repo level. This has been the common thread in this button missing, org level rulesets.
😔 1
s
That's a bummer. We were standardizing quite a few things using org rulesets/enterprise rules. Any equivalent alternatives in Graphite or if not, any plans for that soon? TBH, wouldn't mind enforcing to completely switch over to Graphite but some of these rules help and it's more work to have to replicate at repo level. I'm sure you folks know but even the repo-level workflow config changes/other settings changes are quite a hassle when trying to onboard other projects in the org into Graphite right now sad panda
p
definitely, we are still working to support rulesets in full hopefully in the future but for now i think we are blocked by permissions issues reading from github