We're considering using the merge queue—does it su...
# how-do-im
Martin Ek
10/03/2023, 10:03 PMWe're considering using the merge queue—does it support skipping the queue if a PR is already up to date and rebased? I.e., if you create a branch out of main and all tests have already succeeded on the PR, is it able to skip re-running tests on a new branch before merging? This is a limitation with the GitHub merge queue that has stopped us from using it.
n
Nicholas Yan
10/03/2023, 10:29 PMYes it should!
Nicholas Yan
10/03/2023, 10:29 PM(cc @David Bradford in case you want to add any other context)
m
Martin Ek
10/03/2023, 11:04 PMNice! I'll give it a try then.
j
Jacob Gold
10/04/2023, 1:45 AMI think you may need to ensure that the fast-forward option is selected in order to achieve this behavior
Jacob Gold
10/04/2023, 1:45 AMI also defer to Dave on these things though 🙂
d
David Bradford
10/04/2023, 1:55 PMYes, you should get this behavior in the merge queue if you have fast-forward enabled.
m
Martin Ek
10/04/2023, 4:44 PMThank you, I'll make sure that's enabled
Martin Ek
10/04/2023, 5:13 PMTook a minute but it looks like it worked, nice! Thanks.
🔥 1
Martin Ek
10/04/2023, 7:14 PMIs there any way to add a PR to the merge queue before its tests complete? If it's going to have to rebase a PR anyway it seems like that would save some time
d
David Bradford
10/04/2023, 8:05 PMRight now there is not. I generally recommend against adding anything to the merge queue that has not already passed tests. It is better to hit any failures before you add PRs to the merge queue. Since failures in the merge queue not only impact (slow down) the author of the PR, but everyone else who has PRs in the merge queue.
m
Martin Ek
10/04/2023, 8:05 PMThat's fair, thanks!
Martin Ek
10/04/2023, 11:10 PMIs there a trick to activating the "queue with label" feature? I've added it to the
Add to merge queue via labelMartin Ek
10/04/2023, 11:11 PMHm, when I then went and clicked in the Graphite app instead it commented that it detected the label:
Martin Ek
10/04/2023, 11:11 PMI added the label 5 minutes before
d
David Bradford
10/05/2023, 1:53 PMWe have been seeing some instability with the github API over the last few hours, which could explain why detecting the label was delayed.
👍 1
5 Views