Hey @szaman! This should be the case right now for the "approved" filter on the inbox sections. Could you share a screenshot of what the filters on this section look like? Edit: see Aryaman's comment below
Pranathi Peri
05/16/2023, 7:05 PM
There's a chance you haven't been migrated to the new filters yet (cc @Aryaman)
a
Aryaman
05/16/2023, 7:09 PM
@szaman so today the "has required approvals" filter matches the two criteria:
1. PR has enough approvers with write access to match or exceed the number as set in branch protection rules
2. [coming soon] All codeowners have approved
We don't have the ability to filter on all reviewers have approved today.
s
szaman
05/17/2023, 1:12 PM
i see, is there no way to filter for something like "has 1 or more open review request"? then it would be possible to do a condition for "has required approvals" + "NOT has open review requests", which would give me the view i want
a
Aryaman
05/17/2023, 1:45 PM
Not today, but I’m going to spend some time next week making a few changes to the filtering logic, and I’ll try to accommodate this request if I’m able to. Thanks for the suggestion!