Nikolaus
04/11/2023, 5:08 PMNikolaus
04/13/2023, 4:21 PMelliott
04/13/2023, 8:56 PMStefan Parker
04/14/2023, 2:44 PMStefan Parker
04/14/2023, 3:21 PMStefan Parker
04/14/2023, 3:29 PMMatt Wean
04/14/2023, 5:24 PMWARNING: PR for the following branch has already been merged or closed
It seems like it's only seeing the first one and not the new one that's open.Alejandro Frias
04/14/2023, 5:29 PMmain
branch, I’d love a warning message.
A few times now (and I did this several times when started with graphite as well), a coworker will merge the bottom of a stack. Then forget to repo sync and restack submit locally. Then go to merge the rest of their stack and it’ll merge into the merged PRs branch instead of main
Our quick fix is to just create a new PR with the top of the stack that they tried to merge and we re-run CI and then merge that, linking the old PR stack for posterityszaman
04/17/2023, 10:01 AMChristopher Hiller
04/17/2023, 6:20 PMszaman
04/18/2023, 10:42 AMgt log
, unless you explicitly request it (e.g. with something like gt log --show-archive
.
feature request here: https://app.graphite.dev/changes-requested#request-RrWEjHgb9w7T8Ys6Mdl0Scott Richardson
04/20/2023, 4:03 PMSean Lynch
04/20/2023, 4:47 PMAri Tang
04/20/2023, 6:12 PMHamid Aghdaee
04/20/2023, 9:09 PMJack Kenney
04/20/2023, 9:24 PMgt bu
and gt bd
for the PR reviewing pages)Martin Schenck
04/21/2023, 12:47 PMgt
❤️
However, in our daily work, a few things weren't ideal and/or missing:
1. The biggest impact, at least in my opinion, was the unreliability of Graphite's web interface. For example PRs not showing in the dashboard or listed in the wrong section. Or files missing from the diff view of a PR. And a few smaller things I don't remember. Due to this, a "full switch" from GitHub to Graphite with regards to the web interface is not something I would dare at the moment. Also, sometimes, the Graphite web interface is unusably slow for at least a few minutes. So we still need GitHub, which brings me to:
2. Graphite (by design of the workflow) spams GitHub notifications. Every restacked submission releases a wave of notifications without meaningful content for the reviewer (due to the force push). Also, the additional comments on each PR that it "has been queued to be merged" or "rebased for a merge" is not really relevant to the reviewers (at least in our opinion). So we end up with a GitHub inbox full of Graphite "no-op" notifications. Which leads to us missing actual notifications (from the "Graphite repo" as well as other repos).
Regarding point one, we know that you are working hard and usually resolve these issues quickly. Your team has been very helpful and responsive, thank you for that ❤️ We hope that the web interface will get more reliably so that a full switch is feasible in the future.
Regarding point two, is there anything we can do right now to minimize the notifications count? Or remove "unnecessary" (in our eyes) notifications from the GitHub inbox?
Otherwise, a feature to do so would be nice, though I am not sure what a concrete implementation would look like. Maybe change what comments Graphite does? Or maybe a possibility to let Graphite manage part of my GitHub inbox (mark things as read)?
Thank you for reading and thank you for you work! 🙏Adrian Jost
04/21/2023, 2:16 PMPR:
prefixes and merge status icons.
I would prefer to have just a flat list. That feels soo much less cluttered too me.Vampire
04/22/2023, 1:00 AMgt
forwards unknown subcommands to git
, the completion should also include Git completions if the Git completion is available.
But only where it is actually forwarded of course. gt log
will not be forwarded as far as I have seen, except for the hard-coded gt log long
.Vampire
04/22/2023, 2:24 AMgt log long
would forward additional parameters to git
instead of failing.
For example gt log long -30
to only show the first 30 lines.Vampire
04/22/2023, 3:38 PMJack Kenney
04/25/2023, 9:48 PMJorge Zreik
04/25/2023, 11:45 PMinclude-commit-messages
configuration has been super helpful!
However, the fact that it never includes the first line of the commit message makes it less useful for our use case since our commit messages are usually one-liner bodies. From the docs:
Note that if you only have a single commit on your branch, the first line of the message (i.e. its title) will not be included as this is already the default for the name of the PR.Would be great to have an option to disable this behavior, even if it's hidden away somewhere. Thanks! ✏️⚙️
Jack Kenney
04/26/2023, 4:15 PMLowell Bander
05/01/2023, 9:39 PMJoseph Gilley
05/02/2023, 4:40 PM.graphqls
file extension to be auto-recognized as GraphQL syntax? currently it is defaulting to a simple text file.Pierre Renaux
05/03/2023, 2:26 AMDaniel
05/03/2023, 9:50 PMDaniel
05/03/2023, 10:28 PMTim Boucher
05/04/2023, 2:10 PM