Graphite Community

Ohh that’s why comment jumping wasn’t working for me! :open_mouth:

We should be auto-expanding when a comment in the timeline gets clicked on that is part of a collapsed file. I'll investigate and see if I can tell why are you aren't seeing that behavior.

Looks like it works now(?) — if you fixed anything, good job :rocket:

image.png

cc <@U04AP0M9AES> /<@U02DGFZ1H0D> /<@U02DCQ1C0G6>

Good call out — I don't know if we've thought about this before, but definitely something we should!

we are already working on this ;) <@U04AP0M9AES> 

<@U03E0N4H2RG> you're stealing our thunder! more to come soon :wink: 

Otherwise it requires a reload of each page that’s in the stack and when you’re really utilizing the tool that’s a lot of windows to reload :sweat_smile:

for now you can expand the status bar to get at this info, but we’re looking into ways to make this more discoverable so thank you for the feedback!

Ah cool that’s helpful for now though!
I didn’t realize that would expand to show that info, but if the default was for the panel to be expanded that might be just as good!

Can always close it later if it’s in the way

we’re exploring some options like that!

Awesome, thanks for working on these UX improvements! :tada:

you got it :saluting_face: thank you for the feedback!

We're exploring some changes to the comment flow! <@U02DCQ1C0G6> <@U04AP0M9AES>

But in the mean time, you should be able to use the `cmd J` shortcut to just leave comments instead of opening a review

<@U02RREE9GKH> it’s in the designs :slightly_smiling_face:

Mm, thanks for bringing this to our attention! <@U02DCQ1C0G6> /<@U02DGFZ1H0D> — let's discuss how we should handle GH auto-merge

jumping in on this, it’d be great if the automerge could be configured with metadata or something else to block until specified people/everyone has given approval.

similar to google’s “WANT_LGTM=ALL/&lt;ldaps&gt;” in critique

Github’s version was nice and all, but it led to issues with my team since someone tangentially related would give a LGTM without knowledge on how the feature would affect the rest of the service and we’d need to either rollback or create a fix to unbreak things

&gt; until specified people/everyone
You might be able to configure this via GitHub's branch protection rules

We're starting a beta group for Graphite "merge when ready!" Be sure to respond in the thread/react to be included :slightly_smiling_face:
<https://graphite-community.slack.com/archives/C02DRNL3HQU/p1683923375949469>

Improvement suggestion: display a list of branches to select from on `gt branch delete`  (like you do on `gt bco` )
rationale: sometimes I `get bc` in the wrong directory (I work on several repos), creating a useless branch.

hmm interesting suggestion! cc <@U02DCQ1C0G6> and <@U04HQKF7TSN> for filtering related things

Doesn't necessarily solve your issue, but if you click in you will see a banner that allows you to hide changes since last reviewed

yup! I do already click in and set it to the unreviewed section. this is meant more so for prioritizing which PRs to review

For PRs that require more explanation/context, we include mermaid diagrams in the PR description. Github renders these natively. Today, I have to nav back to Github any time I’m reviewing or updating a PR with diagrams.

<https://github.blog/2022-02-14-include-diagrams-markdown-files-mermaid/>

I miss `diffgrep` too! One hurdle that we would have to cross before we could get to this is that we don't currently store code.

There is work planned around improving the search experience, but code search is unlikely until we are able to store code.

something like `git log -S` ? (aka "git pickaxe")
fun fact: it's available on vanilla git web (bundled with git)
when you launch `git instaweb` it will be on the top right:

thanks for flagging, <@U04V5S7DPN2>! we’ve got some improvements planned here in next week :slightly_smiling_face:

for context, we don’t support clicking on the line of code so that you’re still able to select and copy text from the block — but we will be making the action to leave comments more discoverable!

cc <@U02DCQ1C0G6> for vis

Thanks folks :slightly_smiling_face:  I kind of suspected copy-paste was the reasoning behind it!

Screen Shot 2023-04-06 at 10.30.12 AM.png

Neat :slightly_smiling_face: Thanks again!

glad you like it! keep the feedback coming :blush: 

Good day, It’d be nice to see the description as one of the the right panel options :slightly_smiling_face:

See this thread for details <https://graphite-community.slack.com/archives/C02DRNZELUU/p1678381753611609>

I was thinking this especially today because the GH ops incident is apparently resolved but unfortunately, Graphite is still being pretty sluggish rn. It’s taking a long time to do things like submit comments and add tags, and it’s highlighting how the Graphite UI will eagerly update, but then closing the window prompts about unsaved changes until the change goes through.

I think Github probably uses a service worker under the hood to take these actions so they’re reliable, even if the user closes the window after pressing the button.

No - we currently sync all information with GitHub

ill see if there's an easy way to expose this for you!

cc <@U02DCQ1C0G6> / <@U02DGFZ1H0D> / <@U04AP0M9AES>

thank you for the feedback! we're actively working on improvements here :smile: 

1. no plans yet, we're mainly focused on syncing with GitHub right now
2. <@U02RREE9GKH> 

all the local commands should still work (everything that doesn't require graphite authentication)

is this when you're editing commit message in the CLI or the dashboard?

I’ve been thinking about the same thing <@U03FNT1FLP5>! How would you want this feature to work with gt?

we could also have it generate suggested branch/pr titles

I'd be much less inclined towards branches - we use Linear and that has the magic branch tracking which I use extensively, but that's just me!
But PR titles would be excellent.

I think generally a similar pattern to the summary in the description could be really handy for commits, just maybe a little bit scoped down. We're a remote team and something that I've been trying (and somewhat failing) to do is to write really meaningful commit messages so other engineers can gain context on choices made right in their editor instead of having to go and look at the PR description, work through it and identify things. If gt commit had a `-summarise` flag, it'd encourage smaller commits and then leave a meaningful message!

As a fellow Linear user, we also use the linear branch name pretty much exclusively for our branches.

A summarize flag would be cool for the body of a commit, but I think I would still want control over the title of the commit.

Are you talking about top-level comments?

Screenshot 2023-04-07 at 12.43.18 PM.png

you should be able to resolve threads for comments in the code!

yeah, resolving regularly is fine. I was referring to a templated comment + resolve button to do it all in one button.

Oh gotcha, so a "resolve with comments" type of situation! cc <@U02DCQ1C0G6>

either that (to not need to press “add reply” and then “resolve thread”) or having templated responses so I can press a button that’ll reply “done” (might be hard since there are many variations) and resolve

Ah this is a cool idea, thanks for the suggestion!

I saw this feature and immediately wished for Hack, but at least Jetbrains Mono is there so I’m good. Love being able to choose styles like this :smile:

Also I keep making branches named `create` and `split` and stuff cause I keep typing `git branch split` :sweat_smile:

I’ve run into the same thing. It would be cool if Graphite could infer what the user intends when doing a `gt branch create`  with a detached HEAD (do a split from the topmost branch) and prompt the user to see if they want to do that