https://discord.cloudflare.com logo
Join Discord
Powered by
# workers-discussions
  • d
    and even if i use a smaller file, and the first upload succeeds, a subsequent call (with no post data) will fail
  • d
    (pending state)
  • s
    I can't reproduce that
  • d
    i believe that is because it really depends on how many bytes you're sending. i notice different behavior with different file sizes
  • d
    yes, bugs can happen, but this is rather fundamental to cloudflare tech, and it is broken in both local and experimental
  • s
    Both of which are powered by miniflare
  • d
    also, i've tested on two machines (one intel mac, the other m2 mac), and a windows vm (all tested in chromium based browsers). using the same files, i get the same behavior
  • d
    yes, but supported by cloudflare?
  • s
    do you have a repo so I can test it?
  • s
    I more meant that the bug happening in two places still have the same underlying cause
  • d
    i will create a repo
  • c
    If it helps, the code I put up on based on your original to test it is: https://cdn.discordapp.com/attachments/779390076219686943/1107695148021850184/worker.js
  • d
  • d
    i included a test avi file
  • s
    this is working fine for me with 10mb and 50mb files
  • d
    yes, the online one works fine for me
  • s
    it was hanging until I added an 
    await request.text();
    to the top of the 
    fetch
    handler
  • s
    no, not the online one
  • s
    the code
  • s
    running locally
  • s

    https://cdn.discordapp.com/attachments/779390076219686943/1107697437117796412/image.png▾

  • s
    10mb then 50mb
  • s
    using your AVI file

    https://cdn.discordapp.com/attachments/779390076219686943/1107697507200421988/image.png▾

  • d
    let me look at the code this is based off. i believe this also fails when consuming the body stream, which is how i found this issue
  • s
    Copy code
    js
const HTML = `<!DOCTYPE html>
<html>
  <head>
    <title>File Upload Test</title>
  </head>
  <body>
    <h1>File Upload Test</h1>
    <form id="uploadForm">
      <input type="file" id="fileInput" name="file" />
      <button type="submit">Upload</button>
    </form>

    <script>
      document.getElementById('uploadForm').addEventListener('submit', function (event) 
      {
        event.preventDefault();
        
        var fileInput = document.getElementById('fileInput');
        var file = fileInput.files[0];

        var formData = new FormData();
        formData.append('file', file);

        fetch('/', {method:'POST', body:formData}).then(response => 
        {
            if (response.ok) alert('File uploaded successfully.');
            else alert('Error uploading file.');
        }).catch(error => 
        {
            console.error('Error:', error);
        });
      });
    </script>
  </body>
</html>`;

export default {
  async fetch(request, env) {
    await request.text();
    if (request.method == "GET") {
      return new Response(HTML, { headers: { "content-type": "text/html" } });
    }
    let response = new Response("{}");
    response.headers.set(
      "Access-Control-Allow-Headers",
      "Content-Type, X-Json"
    );
    response.headers.set("Access-Control-Allow-Origin", "*");
    response.headers.set("Access-Control-Allow-Methods", "POST, GET, OPTIONS");
    response.headers.set("Access-Control-Max-Age", "86400");

    return response;
  },
};
  • s
    that is the worker using 
    --local
  • s
    without 
    await request.text();
    it was hanging, but no errors
  • d
    the reason why i didn't include something like await request.text() was just to make the example as simple as possible, but the code the example is based off does try to consume the body
  • s
    well even without it I don't get an error
  • d
    with --local it will hang. with --experimental local it will error
1...246524662467...2509Latest