Unsmart | Tech debt
03/05/2023, 5:54 AMdave
03/05/2023, 6:13 AMdave
03/05/2023, 6:23 AMAdvany
03/05/2023, 8:38 AMSkye
03/05/2023, 9:22 AMdave
03/05/2023, 3:01 PMdave
03/05/2023, 3:02 PMdave
03/05/2023, 3:37 PM.put()
resolves, does that always mean it succeeded?HardAtWork
03/05/2023, 3:38 PMR2Object
if you want to be 100% sure?dave
03/05/2023, 3:39 PMtypescript
if(c.env.R2_LOGGING) {
s3_promise_results.push(new Promise((resolve, reject) => {
return c.env.R2_LOGGING.put(filename, incoming_arraybuffer, {
httpMetadata: {
contentType: 'application/json',
contentLanguage: 'en'
}
}).then((r2_result) => {
console.log(`Uploaded ${r2_result.key} to R2 bucket successfully`);
resolve(new Response());
}).catch((r2_error) => {
console.error(`Failed to upload to R2 bucket`);
reject(r2_error);
});
}));
}
dave
03/05/2023, 3:39 PMSkye
03/05/2023, 3:40 PMresolve(new Response())
looks a bit weird in my eyesSkye
03/05/2023, 3:40 PMdave
03/05/2023, 3:42 PMdave
03/05/2023, 5:50 PMSkye
03/05/2023, 5:58 PMdave
03/05/2023, 5:59 PMSkye
03/05/2023, 5:59 PMdave
03/05/2023, 6:00 PMheftymouse
03/05/2023, 6:16 PMzegevlier
03/05/2023, 6:16 PMzegevlier
03/05/2023, 6:17 PMheftymouse
03/05/2023, 6:17 PMErisa | Support Engineer
03/05/2023, 6:18 PMheftymouse
03/05/2023, 6:18 PMheftymouse
03/05/2023, 6:18 PMErisa | Support Engineer
03/05/2023, 6:19 PMheftymouse
03/05/2023, 6:19 PMdave
03/05/2023, 7:13 PMJames
03/05/2023, 7:14 PM