I guess it is, yes, but I only tested with a single DO.

This is over a websocket right?

yep

I was thinking about multiple connections - if it's 10k per worker-DO connection then it's not so bad, but if the DO itself gets locked up, well...

Wouldn't help me, since my websockets are long-lived.

Oh, I was assuming you'd have the ability to reconnect if the connection drops - then you'd be on a new worker. Doesn't matter if it's the DO itself, of course.

Ah, I see. Dropping the connection still creates a glitch in the user experience, so that would be less than optimal.

Yeah, that absolutely would..

Okay, going to bed, it's late here. I'll check back in the morning. Thanks!

Cheers!

here is a PR fixing the problem with the env vars not being present when using ESM: https://github.com/cloudflare/kv-asset-handler/pull/188 let me know if any changes are needed

i merely patched the crash blocking us, but a proper solution would probably pass the env object as a third parameter or similar. however i didn't want to mix this fix with a necessary discussion about how to change the public API going forward. would be nice if this could be released as a fix, at least in some esm branch on npm

@kristian @lukeed who wakes up first? 😂

Hmm.. guess we are going to need both of you? Seems you don’t trust me... 🥺😢

Will do!

Awesome 🙂 cc @James

missing piece in the puzzle though is how we get at the contents of what was previously in the global __STATIC_CONTENT_MANIFEST - the env object does not contain it anymore

Just merged actually 👍 I’m not super familiar with ESM or DOs, but this should at least prevent the crash

great, thanks! looking forward to the next release

If you don’t mind keeping us updated with any progress you make getting this to work in that open issue, that would be awesome. I’m not too sure yet about the best way to properly solve this in a backwards-compatible way, so very open to suggestions.

very open to, though i would need some pointers where to find the __STATIC_CONTENT_MANIFEST after moving to ESM?

do you know who is working on the workers-site and where in the wrangler repo the code for __STATIC_CONTENT_MANIFEST is located?

found it in

src/upload/form/mod.rs

so i'll see why it's not part of the env - i guess it has not been updated. any branch with work on this?

With wrangler? I’ve no idea sorry. No other work has been done in

kv-asset-handler

that I’m aware of though.

thanks, i guess i should head over to #818615097731317802 then?

i see there is also #831143699999752262, maybe that's more suitable

Up to you really. It’s a very wide topic scope involving Wrangler, DOs, and Workers Sites. Is there an open discussion on the wrangler repo about this yet? I’d guess some changes need to be made there to get the env vars set and published correctly?

cool, i will have a look in the wrangler repo. i just wonder who i should talk to to learn if somebody is working on this

I know @User did some work to get Wrangler Custom Builds and Workers Sites playing nicely together. I wonder if the scope of work will be similar here 🤔

Hello, folks. I'm trying to find information on what are the limits for open websocket connections, can anyone help?