Channels
#box-products
Title
# box-products
d
danmurphy
04/29/2022, 9:18 PMAny idea on what is causing this? Just trying to install a package that has been used plenty of times before with the same version of commandbox in our container (can recreate locally too).
Error cloning github repository org.eclipse.jgit.api.errors.CheckoutConflictException: Checkout conflict with files:tests/resources/app/handlers/Main.cfcb
bdw429s
04/29/2022, 9:27 PMI feel like if seen this before
Can you ensure the old package uninstalled fully?
d
danmurphy
04/29/2022, 9:28 PMLike, blow away the folder and then try again?
b
bdw429s
04/29/2022, 9:28 PMYeah
d
danmurphy
04/29/2022, 9:30 PMI blew away the folder and then even the entire modules directory. It always fails on
cfcollectionThe container is a different version than locally (commandbox 5.0.1 and cfcollection 2.8.0) but I can reproduce the same error locally with commandbox 5.4.2 and cfcollection 2.10.2.
b
bdw429s
05/01/2022, 1:55 AMI wonder if it's related to the new jgit version in CommandBox 5.5.0. I updated the jar.
Oh wait, Only on my phone and didn't read that right. You said you can recursive reproduce on 5.4.2
Seems the issue is with cfcollection perhaps
@elpete have you seen this?
e
elpete
05/01/2022, 4:09 AMNo. I also haven't touched that repo in years.
b
bdw429s
05/03/2022, 12:10 AM@danmurphy I got a chance to try this locally and it seems to be working ok for me
Copy code
❯ install cfcollection@2.8.0 --verbose
√ | Installing package [forgebox:cfcollection@2.8.0]
|---------------------------------------------------------------
| Verifying package 'cfcollection' in forgebox, please wait...
| Installing version [2.8.0].
| Verified entry in forgebox: 'cfcollection'
| Deferring to [github] endpoint for forgebox entry [cfcollection]...
| Using branch [v2.8.0]
| Cloning Git URL [<https://github.com/elpete/cfcollection.git>]
| remote: Enumerating objects
| remote: Counting objects (45)
| remote: Compressing objects (43)
| Receiving objects (17931)
| Resolving deltas (3814)
| Checking out files (74)
| Available branches are refs/heads/master,refs/remotes/origin/dependabot/npm_and_yarn/is-my-json-valid-2.20.0,refs/remotes/origin/dependabot/npm_and_yarn/macaddress-0.2.9,refs/remotes/origin/dep
| endabot/npm_and_yarn/marked-0.3.19,refs/remotes/origin/dependabot/npm_and_yarn/sshpk-1.16.1,refs/remotes/origin/dependabot/npm_and_yarn/stringstream-0.0.6,refs/remotes/origin/development,refs/r
| emotes/origin/master,refs/remotes/origin/transducers
| Storing download in artifact cache...
| Done.
| C:\sandbox\/box.json updated with dependency.
| Installing to: C:\sandbox\/modules/cfcollection
| -> 11 File(s) Installed
| -> 17 File(s) ignored
| Eureka, 'cfcollection@2.8.0' has been installed!I am using CommandBox 5.5.0 (with the workaround in place for github cloning to work)
d
danmurphy
05/03/2022, 12:14 AMThanks for following up @bdw429s . So that might be what we have to do then. Our current dockerfile is running a previous version of commandbox (5.x something). I wasn't aware there was a fix for GitHub cloning. What was the issue exactly?
b
bdw429s
05/03/2022, 12:44 AMCheck the thread from today in #box-products
👍 1
The 5.5 release had a regression that crept in days before I released that managed to screw up jGit
d
danmurphy
05/03/2022, 12:49 AMAh, interesting. Thanks for the info. I'm hitting this on commandbox v5.0.1 and v2.8.0 of cfcollection or 5.4.2 and 2.10.2. So must be a similar thing?
b
bdw429s
05/03/2022, 12:50 AMDunno, I can't reproduce it so ¯\_(ツ)_/¯
It's possible the new version of jGit in the latest CommandBox is what allows it to work now
d
danmurphy
05/03/2022, 12:55 AMNot positive of the Lucee versions off the top of my head, but it sounds like that matters too. I think it was 5.2.x and 5.3.6 with each combination above, respectively.
b
bdw429s
05/03/2022, 1:56 AM@danmurphy Can you give it a quick test on CommandBox 5.5.1 when you get a chance?
d
danmurphy
05/03/2022, 2:05 AMWill do tomorrow. Thanks!
b
bdw429s
05/03/2022, 2:06 AM👌
d
danmurphy
05/03/2022, 6:27 PM@bdw429s It looks like installing cfcollection 2.10.2 (which failed on CommandBox 5.4.2) gives the same error with CommandBox 5.5.1.
b
bdw429s
05/03/2022, 6:40 PMHmm, dunno then. I can't reproduce this
I have an idea why it's happening
That folder is different between the master branch and the 2.x tags
CommandBox clones the repo and then checks out the branch/tag/commit and I think those files may be untracked in some of the tags and tracked in other tags, but I'm just guessing
It's also worth noting the 2.x versions of cfcollection are very old
d
danmurphy
05/03/2022, 6:43 PMRight - I just didn’t want to address whatever breaking changes might have happened yet.
b
bdw429s
05/03/2022, 6:43 PMI have a feeling this boils down to a bug in JGit's checkout command
d
danmurphy
05/03/2022, 6:45 PMYou can’t reproduce the error if you try to
install cfcollection@2.10.2b
bdw429s
05/03/2022, 6:45 PMI couldn't reproduce on
2.8.0That would be really weird, right?I don't think anything is weird any longer. I've seen too many things that defy reason 🙂
😂 1
Copy code
❯ install cfcollection@2.10.2 --verbose
√ | Installing package [forgebox:cfcollection@2.10.2]
|----------------------------------------------------------------
| Verifying package 'cfcollection' in forgebox, please wait...
| Installing version [2.10.2].
| Verified entry in forgebox: 'cfcollection'
| Deferring to [github] endpoint for forgebox entry [cfcollection]...
| Using branch [v2.10.2]
| Cloning Git URL [<https://github.com/elpete/cfcollection.git>]
| remote: Enumerating objects
| remote: Counting objects (45)
| remote: Compressing objects (43)
| Receiving objects (17931)
| Resolving deltas (3814)
| Checking out files (74)
| Available branches are refs/heads/master,refs/remotes/origin/dependabot/npm_and_yarn/is-my-json-valid-2.20.0,refs/remotes/origin/dependabot/npm_and_yarn/macaddress-0.2.9,refs/remotes/origin/dep
| endabot/npm_and_yarn/marked-0.3.19,refs/remotes/origin/dependabot/npm_and_yarn/sshpk-1.16.1,refs/remotes/origin/dependabot/npm_and_yarn/stringstream-0.0.6,refs/remotes/origin/development,refs/r
| emotes/origin/master,refs/remotes/origin/transducers
| Storing download in artifact cache...
| Done.
| C:\sandbox\rewritespace\/box.json updated with dependency.
| Installing to: C:\sandbox\rewritespace\/modules/cfcollection
| -> 11 File(s) Installed
| -> 17 File(s) ignored
| Eureka, 'cfcollection@2.10.2' has been installed!d
danmurphy
05/03/2022, 6:47 PMYeah - the error happens in certain combinations of commandbox and cfcollection, it seems.
b
bdw429s
05/03/2022, 6:48 PMI'm on CommandBox 5.5.1 and java 11.0.6
d
danmurphy
05/03/2022, 6:48 PMWow, you really didn’t get the error though.
Ah, java version. Didn’t think about that.
b
bdw429s
05/03/2022, 6:48 PMnope
I'm on Windows. You?
d
danmurphy
05/03/2022, 6:48 PMMac.
b
bdw429s
05/03/2022, 6:49 PMCould have something to do with that
is your FS case sensitive?
d
danmurphy
05/03/2022, 6:49 PMBut can reproduce this in our Docker environment just the same.
b
bdw429s
05/03/2022, 6:49 PMJust guessing- there's so many factors at play
JGit may have different code paths it takes internally based on the OS or FS
d
danmurphy
05/03/2022, 6:50 PMNo on the case sensitivity, locally at least. Probably within the Docker environment.
Well, I’ll take this as, get all the things more current (cfcollection, java, etc.). Thanks for the troubleshooting though.
b
bdw429s
05/03/2022, 6:52 PMSomeone should probably get a repro case together to try and submit a ticket to JGit
Not that they may much attention to tickets 😕
Lots of hits on Google for the error message
Have you read through all of those?
Do you have any process that may be writing to those files as soon as they are cloned?
Pretty much all the hits on Google say this happens when you are pulling commits and have local changes
d
danmurphy
05/03/2022, 6:56 PMI read through a bunch that all seemed related to random repos. I didn’t realize the common thread might have been jGit.
I have blown away my entire modules folder and this still happens, but maybe the conflicting files are with commandbox or jGit somewhere?
b
bdw429s
05/03/2022, 6:57 PMwell yes, JGit is the library throwing the error, lol
CommandBox is just asking JGit to clone the repo and check out the branch, that's all
JGit is the one failing
Sadly my life is now reduced to tracking down a million bugs in a million 3rd party libraries these days 😕
😳 1
e
elpete
05/03/2022, 6:59 PMHe exaggerates. It's only 834,223 bugs in 432 libraries. 😉
😁 2
b
bdw429s
05/03/2022, 6:59 PMWhen I asked if a process could be modifying the files, I mean something running in the background that may immediately be writing ot them as soon as they are placed on disk. basically interfering with the clone command.
e
elpete
05/03/2022, 7:00 PMHave we tested with the entire box.json Dan is using?
It could be the clone command is somehow overwriting paths in the wrong folders.
d
danmurphy
05/03/2022, 7:00 PMHmm, right. Not that I can think of. The only thing would be some kind of cfformat command maybe, but we pin down the directories we watch and I don’t have that running atm.
Good question. No, not with my specific box.json file.
b
bdw429s
05/03/2022, 7:05 PM@danmurphy Good news-- I am able to reproduce this in a docker container
Copy code
docker run -it foundeo/minibox box install cfcollection@2.10.2 --verboseSo maybe it's related to a *nix file system
d
danmurphy
05/03/2022, 7:06 PMMy coworker can reproduce it as well.
b
bdw429s
05/03/2022, 7:06 PMminibox is just a CommandBox light instance so there's nothing else going on there
d
danmurphy
05/03/2022, 7:06 PM(he is on a Mac as well)
b
bdw429s
05/03/2022, 7:16 PM@danmurphy I think I figured it out
In my docker container test, I cd'd into the temp folder where the Git repo was being checked out
When I run
Copy code
git status Copy code
modified: tests/resources/app/handlers/Main.cfcWhen I diff the file
Copy code
git diff tests/resources/app/handlers/Main.cfc Copy code
index cf160826..b3391953 100644
--- a/tests/resources/app/handlers/Main.cfc
+++ b/tests/resources/app/handlers/Main.cfc
@@ -1 +1 @@
-component extends="coldbox.system.EventHandler"{MM // Default ActionM function index(event,rc,prc){M prc.welcomeMessage = "Welcome to ColdBox!";M event.setView("main/i
ndex");M }MM // Do somethingM function doSomething(event,rc,prc){M setNextEvent("main.index");M }MM /************************************** IMPLICIT ACTIONS ****
*****************************************/MM function onAuthenticationFailure( event, rc, prc ) {MM }MM function onAuthorizationFailure( event, rc, prc ) {MM }MM function onAppInit(ev
ent,rc,prc){MM }MM function onRequestStart(event,rc,prc){MM }MM function onRequestEnd(event,rc,prc){MM }MM function onSessionStart(event,rc,prc){MM }MM function onSe
ssionEnd(event,rc,prc){M var sessionScope = event.getValue("sessionReference");M var applicationScope = event.getValue("applicationReference");M }MM function onException(
event,rc,prc){M //Grab Exception From private request collection, placed by ColdBox Exception HandlingM var exception = prc.exception;M //Place exception handler below:MM
}MM function onMissingTemplate(event,rc,prc){M //Grab missingTemplate From request collection, placed by ColdBoxM var missingTemplate = event.getValue("missing
Template");MM }MM}M
\ No newline at end of file
+component extends="coldbox.system.EventHandler"{M // Default ActionM function index(event,rc,prc){M prc.welcomeMessage = "Welcome to ColdBox!";M event.setView("main/i
ndex");M }M // Do somethingM function doSomething(event,rc,prc){M setNextEvent("main.index");M }M /************************************** IMPLICIT ACTIONS ****
*****************************************/M function onAuthenticationFailure( event, rc, prc ) {M }M function onAuthorizationFailure( event, rc, prc ) {M }M function onAppInit(ev
ent,rc,prc){M }M function onRequestStart(event,rc,prc){M }M function onRequestEnd(event,rc,prc){M }M function onSessionStart(event,rc,prc){M }M function onSessionEnd(event,r
c,prc){M var sessionScope = event.getValue("sessionReference");M var applicationScope = event.getValue("applicationReference");M }M function onException(event,rc,prc){M
//Grab Exception From private request collection, placed by ColdBox Exception HandlingM var exception = prc.exception;M //Place exception handler below:M }M
function onMissingTemplate(event,rc,prc){M //Grab missingTemplate From request collection, placed by ColdBoxM var missingTemplate = event.getValue("missingTemplate
");M }M}M
\ No newline at end of fileWhich reminded me that the line endings were all jacked up in the repo for this file
e
elpete
05/03/2022, 7:18 PMBOM?
b
bdw429s
05/03/2022, 7:18 PMno
it's not encoding
it's line endings
e
elpete
05/03/2022, 7:18 PMThe }M
b
bdw429s
05/03/2022, 7:18 PMif you view the file on github, it's also messed up
Luis used to have this issue on his mac back before Git had automatic line endings
e
elpete
05/03/2022, 7:18 PMI had this with some files copied from coldbox at one point.
I had the do a dos2unix command on them to fix them.
And then commit.
I can check that for this repo.
b
bdw429s
05/03/2022, 7:19 PMd
danmurphy
05/03/2022, 7:19 PMYeah, I remember that specifically with layout files, if copied from the default ColdBox layout.
b
bdw429s
05/03/2022, 7:19 PMSo what's happening here is when Git checks out the files, I'm fairly sure it's auto-fixing the messed up line endings
e
elpete
05/03/2022, 7:19 PMYup. That's it.
b
bdw429s
05/03/2022, 7:20 PMAnd that makes the file show as modified
d
danmurphy
05/03/2022, 7:20 PMInteresting!
b
bdw429s
05/03/2022, 7:20 PMSo the subsequent checkout command fails
FWIW, CommandBox also has a built in utility for fixing line endings
Copy code
line-endings ?If you can get those fixed on the master branch, that may fix this
Since what CommandBox does is
• clone repo which will be on default branch (master, usually)
• checkout commitish that was asked for
So as long as we can get master to clone cleanly, switching to the tag should be fine
And FWIW, I still think this should be logged as a bug in JGit because I just did a test clone with the Git CLI and it clones with no location modifications
So JGit is doing something differently
And since it's most likely windows line endings which are in the file, that also would make sense why Windows had no issues since those line endings were fine there.
it was only on *nix that JGit tried to "fix" them
d
danmurphy
05/03/2022, 8:21 PMWell, that was some good investigative work @bdw429s.
e
elpete
05/03/2022, 9:16 PMThis is now fixed on the latest, but the latest is 3.6.4.
2.10.2 was August 2017
3.6.3 was at least February 2020. 😉
d
danmurphy
05/05/2022, 8:13 PMThanks for getting this fixed! Trying to go through the updates here…it is painful, ha. It has become a chain of events that is dipping into qb returnFormat now. I’ll post in the main thread again about what I’m seeing.
2 Views