https://pinot.apache.org/ logo
Join SlackCommunities
Powered by
# pinot-dev
  • k
    looks promising, any volunteers to give this a shot in Pinot and compare the performance?
  • k
  • s
    Let me take another look
  • m
  • m
    @User I don't see Travis build in your PR: https://github.com/apache/incubator-pinot/pull/5491
  • m
    Let me know if the failure is not caused by your change
  • a
    Just started looking into this
  • m
    Thanks
  • a
    Easy way to find out is rollback of the change
  • a
    looks like a different set of tests failed for a TE commit later on
  • m
    Curious though, why did the PR not have a travis build? Is it because it is outside of the src dir?
  • a
    apparently. I always wait for CI
  • a
    did touch pinot-tools though
  • m
    The failure seems to be with errors like;
    Copy code
    ./.travis/.travis_quickstart.sh: line 70: [: : integer expression expected
+sleep 1
  • m
    @User ^^
  • m
    Seems you modified 
    .travis
  • j
    No, I didn’t modify 
    .travis_quickstart.sh
  • m
    Let's wait until @User’s latest build on master comes back. Given that commit's after his failed for other reasons, this could likely be an intermittent issue.
  • a
    we should know shortly
  • s
    that is because quick start terminated, i think. A shell expression of sort 
    if [ ${x} -eq 1 ]
    fails if the shell var 
    x
    is never set to anything.
  • m
    But in the following commit, quickstart seemd to have passed.
  • s
    hmm, not sure, could it be a temporary failure in travis? (not unheard of)
  • a
    seeing a lot of this - is this intentional?
    seeing a lot of this - is this intentional?
  • a
  • a
    parse errors?
  • a
    ok looks like this failed again. Let’s revert the commit and go from there
    ➕ 1
  • a
  • h
    Gentle reminder on helping to validate release-0.4.0-RC2. The email was sent to dev@pinot.apache.org two days ago. Here's the direct link to the email thread: https://mail-archives.apache.org/mod_mbox/pinot-dev/202006.mbox/%3CCAJ-bhbSVY6DYC%3DHxCpEytwksNP8Ys4yq0qe83TjustE2_LPFyA%40mail.gmail.com%3E
    👍 2
  • a
    looks like CI is still failing, even after reverting the recent PR. (CI on the PR of the revert succeeded!) Seems like an unrelated issue at this point
  • a
1...111213...30Latest