https://pinot.apache.org/ logo
Join SlackCommunities
Powered by
# pinot-dev
  • m
    If so, at the very least we need to document
  • s
    That is not backward compatible issue
  • m
    If you need to roll back
  • m
    You cannot roll back
  • m
    I think we should document that
  • s
    New release can read the old segments
  • s
    So it is backward compatible
  • m
    Yeah you are right.
  • m
    But we did run into a situation where we could not roll back
  • s
    Right
  • m
    So we should document that, there is a format change that prevents rollback
  • k
    where is this happening?
  • s
  • s
  • h
    The release is cut from: https://github.com/apache/incubator-pinot/commit/008be2db874dd1c0d7877ce712842abd818d89d1 With cherry-picking: https://github.com/apache/incubator-pinot/commit/7f10c5c9a571ba1ca8d8ebee5d2b74fc3b05cd7b We can continue the discussion. That PR is not included in this release.
  • s
    May be I can cherry-pick the commits into the release branch
  • h
    was the issue introduced in 5470?
  • s
    issue was introduced in 5256.. it is addressed in 5470 and 5472
  • h
    ok got it
  • h
    let me try to cherry-pick 5470 and 5472 later today
  • m
    @Sid is the problematic PR not part of the release?
  • m
    If not, we can skip
  • m
    If yes, we need to discuss the plan
  • s
    it is part of the release (PR 5256) which is why I suggest to cherry-pick
  • s
    Current RC is from PR 5453
  • m
    Got it
  • s
    the issue we found was that once you roll forward, there is no going baack because the new code would have written segments. We had to roll back due to performance problems.
  • m
    @User Just to be clear, with the patch is only for fixing performance issue, rollback is still not possible, correct?
  • s
    right because there is a format change of writing 8-byte chunk offsets for both var and fixed byte raw indexes.
  • k
1...101112...30Latest