Dendron

so its passing on my end:

PASS src/__tests__/engine-server/drivers/file/schemaParser.spec.ts (83.95 s)
PASS src/__tests__/pods-core/v2/MarkdownExportPodV2.spec.ts (84.974 s)

looking at the specific errors, it looks like its running the old code but with the new code

```
  ● GIVEN exporting markdown with siteUrl set somewhere › AND WHEN siteUrl ONLY set on config › WHEN run md export pod › AND WHEN exporting nonIndex note › THEN note url should match siteUrl with note id

    Failed: "[Foo](https://foo.com/notes/foo) found 0 times, expected more than 0 in # Parent

    foo body


    [Foo](https://foo.com/notes/foo.html)"

      113 |     describe("WHEN run md export pod", () => {
      114 |       describe("AND WHEN exporting nonIndex note", () => {
    > 115 |         test("THEN note url should match siteUrl with note id", async () => {
          |         ^
      116 |           await runEngineTestV5(
      117 |             async (opts) => {
      118 |               const result = await runPod({

      at Env.it (../../node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:95:24)
      at Suite.<anonymous> (src/__tests__/pods-core/v2/MarkdownExportPodV2.spec.ts:115:9)
      at Suite.<anonymous> (src/__tests__/pods-core/v2/MarkdownExportPodV2.spec.ts:114:7)
```

can you try rebuilding? https://docs.dendron.so/notes/mwDT040wz5nBKtctjvNrQ.html#cleanup

one thing i want to mention is that my npx is somehow using Chinese. Maybe this can cause some problem?

And I don't know how it goes into Chinese. I set my whole environment to English(US), from Mac to VSCode. and my settings.json has no "chi" nor "zh", nor "cn"

only one thing was related to Chinese encoding 
```
  "[matlab]": {
    "files.encoding": "windows1252"
  },
  "matlab.linterEncoding": "gb2312",
```

hmm, that shouldn't affect it. what version of node are you using?

got it. can you try with 14.x? and initialize the monorepo using `yarn setup`

basically, start from  https://docs.dendron.so/notes/64f0e2d5-2c83-43df-9144-40f2c68935aa.html

i know node v17 has some problem in react . some ssl things. lemme try this first and if it downt work I change to v14

yeah, just noticed that 😅 

we haven't tested it with +14 so might need to update it

i saw it passed some tests that failed before. but there are still some FAIL-s

so the github publish pod is the flaky test i was talking about earlier. you can actually remove it `src/__tests__/pods-core/GithubIssuePod.spec.ts`

my console can't show more.. and my `yarn.lock` has changed..

so `rm packages/engine-test-utils/src/__tests__/pods-core/GithubIssuePod.spec.ts && cd packages/engine-test-utils && yarn build`

done. then i run ther testAll.sh again? (`./bootstrap/scripts/testAll.sh`)

great . I'll let you know the outcome. thanks.

I think we can maybe make the .sh output to some file? the report seems too long to show in the terminal..

<@!711453238653616139> if you want lets share screen.. it might be easier?

got it. these tests are failing because we're trying to run all tests in parallel and depending on the hardware, some of the tests will timeout. 
at this point, you should be able to use vscode to develop and run single file tests by following instructions in https://docs.dendron.so/notes/99q7A73uGmCwu2KvSHZro.html#executing-tests

when you are ready to submit a pull request, we have a github action that will run the integration tests

I'll try to submit the PR then. The single file tests are not very useful in my case since the typo occurs in many places..

got it. yeah, its okay - would let the gh action test suite take care of it and we'll also inspect the changes. meanwhile we're also cleaning up the flaky tests

I discard all changes from the master then

<@!789222250628251666> Can you give me a "Horticulturalist" role?

did you already make a code contribution? we typically award those once we merge a pull request

umm i'm just following the "Community PR Review Checklist" and it feels weird to git the role before accept.

tho it didn't mention anything about merge 
> if its your first pull request and you're on our Discord, make sure that Kevin gives you the horticulturalist role by adding your discord as part of the description

got it - need to change the ordering on that. thnxs for letting us know

The extension of "sort imports" made me refactored my code before, when I used AWS and Firebase - They couldn't initialize correctly.

I reverted all changes on import. I think we can try again with the CI now. https://github.com/dendronhq/dendron/pull/2699

just merged in the changes. thanks for the contribution 🙂

In the `activate` of `extension.ts`, I notice we call `_setupCommands({ ws, context, requireActiveWorkspace: false });` and `_setupCommands({ ws, context, requireActiveWorkspace: true });`. How is requireActiveWorkspace defined? Is it for commands that need the engine in the constructor/execute/run?

Just wondering b/c default is false even though many commands seem to use the engine.

I think it's whether the command needs a Dendron workspace to be loaded or not (i.e. SetupWorkspace vs. LookupNote). 

The default is probably false because of backwards compatibility.

Gotcha, thanks! Just some learnings from my end. The reason why `CopyNoteLink` test was flaky is b/c the constructor is trying to access the engine which at the time of setup may not necessarily be there. Should have fix out soon

could anyone point me to where shortcuts are managed in the repo? so i can dig into it - my goal is to add a shortcot for swapping task states with a key chord basically

the way we would do this:
- create a new command (eg. toggle task state)
- you can add a custom shortcut to the command (might leave it blank initially since getting keyboard shortcuts that don't conflict is tricky)

leaving it blank seems fine if its bindable by the user

- bonus: you can add arguments to commands so you could, for example, map a shortcut to set the state of a task vs toggling

yeah should be able to build up any functionality from those units

if you run into any blockers, feel free to post here 🙂

looks like the dendron plugin quickstart link is dead - was this moved to a dendron note?

https://github.com/dendronhq/dendron/blob/master/CONTRIBUTING.md
looking at this

ah, thanks for the catch. yeah, the correct link is here: https://docs.dendron.so/notes/64f0e2d5-2c83-43df-9144-40f2c68935aa

the theme used to render the command flow diagram is really hard to read

i know the docs are in dendron, how do i open the workspace docks under dendron?

maybe i misunderstood - i guess you run dendron in a seperate instance and have the vault open there? (sorry im new to vs code itself so i don't know the optimal way to have the dendron notes and the code open at the same time)

this used to render in a different color when published. May have changed recently as we updated mermaid. Do you mind opening an issue for this? 🙏🏻

If you clone the Dendron monorepo, it includes a native workspace that contains `dendron-docs` and `dendron-site`. So when you open the monorepo, you can have dendron enabled and use lookup as if you have those two vaults in a dendron workspace at the same time you are working on Dendron.

<@237275842273738762> https://github.com/dendronhq/dendron/issues/2725
created

<@367127050970071051> approved https://github.com/dendronhq/dendron/pull/2408 - added a comment about adding docs

I went ahead and added the docs: https://github.com/dendronhq/dendron-site/commit/51922c2eba67ee1a631c3d8274033b68e94807a2

I made a mistake and I wasn't on the dev branch, but I hope this is ok

all good. this will go out with next weeks release 🙂

here's the next thing I've got my eye on: <https://github.com/dendronhq/dendron/issues/2765>

hoping to add hierarchy refactoring to the CLI

nice! let me know if you want to take it on or want any pointers to get started 🙂