https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • k

    kevins8

    03/18/2022, 9:44 PM
    https://github.com/dendronhq/dendron/blob/enhance/self-contained-vaults-step-2/packages/plugin-core/src/WorkspaceWatcher.ts#L329:L329
  • k

    kevins8

    03/23/2022, 10:19 PM
    @User for anyone interested in seeing an end to end pairing/debug session in Dendron, we have a recording of me and @User debugging https://github.com/dendronhq/dendron/issues/2617 below https://www.loom.com/share/99cdf1057d0247bf97b8355902850167
  • m

    Maxotronic

    03/24/2022, 7:01 AM
    Can I assume schema IDs are unique in a vault? Eg if a user has a couple `.schema.yml`'s (schema modules) are they expected to uniquely id each schema across modules? Or should I play it safe and identify each schema not just with its
    id
    but its containing module/domain name
  • s

    SeriousBug

    03/24/2022, 7:16 AM
    I believe the ids have to be unique, you can rely on that. Actually I'm not super sure about schemas
  • m

    Maxotronic

    03/24/2022, 7:19 AM
    Im gonna play it safe 😄
  • k

    kevins8

    03/24/2022, 3:03 PM
    they are currently unique. right now, the way schemas are resolved is that the last schema wins (aka: if two schemas have the same id, the schema that was loaded last will be the recognized schema)
  • d

    dagriefaa

    03/28/2022, 10:41 AM
    what is
    dendron-next-server
    currently used for?
  • h

    hikchoi

    03/28/2022, 11:13 AM
    I believe the graph views are using
    dendron-next-server
    right now. I think we have plans to move this over to
    dendron-plugin-views
    in the near future.
  • j

    Joshi

    03/30/2022, 3:10 PM
    How do we aim to handle the routing with plugin-views like we do in dendron-next-server? https://github.com/dendronhq/dendron/blob/master/packages/dendron-next-server/hooks/useGraphElements.tsx#L561
  • k

    kevins8

    03/30/2022, 3:16 PM
    How do we aim to handle the routing with plugin-views like we do in dendron-next-server? https://github.com/dendronhq/dendron/blob/master/packages/dendron-next-server/hooks/useGraphElements.tsx#L561 i believe the only reason we use the router in the graph view is to pass in port & workspace to the graph. this is something that is now available via the redux store for
    plugin-views
    see how we access and query for notes in the new preview -> https://github.com/dendronhq/nextjs-template/blob/main/components/DendronNotePage.tsx#L86:L86
  • p

    Pablo LION

    04/05/2022, 2:53 AM
    Hi all. I want to PR this issue(https://github.com/dendronhq/dendron/issues/2684) and I'm having some trouble with the design: Since we are checking some front matter scope similar to "publish", should we re-use some code from publish? But when trying to reuse, I see that the current export is not a CLI command, and the
    publish
    as an
    export
    entry.
  • h

    hikchoi

    04/05/2022, 3:12 AM
    added some comments in the issue.
  • p

    Pablo LION

    04/06/2022, 12:30 AM
    to add a function of "generate schema of vault", if I want to the test it, do I need to disable the dendron extension?
  • s

    SeriousBug

    04/06/2022, 12:31 AM
    When you use the "Run Dendron Extension (local)" debug option, it disables all installed extensions so you can test just your version
  • p

    Pablo LION

    04/06/2022, 12:32 AM
    Good to know that. Thanks
  • p

    Pablo LION

    04/06/2022, 12:42 AM
    it seems that the link in "make sure the commit message follows Dendron's commit style" from (https://gist.github.com/kevinslin/5d1a6663638259e7dbd33b01975cc00f) is outdated
  • s

    SeriousBug

    04/06/2022, 12:43 AM
    Ah, we actually stopped following that. You can name commits whatever you want, we just ask for a descriptive PR name.
  • p

    Pablo LION

    04/06/2022, 1:06 AM
    I'm starting with a very small fix (typo). followed the run test
    dendron/bootstrap/scripts/testAll.sh
    (the "Run Task: Test (bootstrap)" didn't work) , it fails on the master branch.. did you updated your test process as well?
  • k

    kevins8

    04/06/2022, 1:07 AM
    what tests are failing? we currently have a few cases that are flaky
  • k

    kevins8

    04/06/2022, 1:07 AM
    you can always submit a pull request on draft mode if you want someone on the team to review
  • p

    Pablo LION

    04/06/2022, 1:09 AM
    it's quite long so i didn't publish.. The first FAIL happened in the first 10 lines
  • k

    kevins8

    04/06/2022, 1:33 AM
    looks like a legitimate failure - site url isn’t set. can you try running the test with just the contents of master without any changes as a sanity test?
  • p

    Pablo LION

    04/06/2022, 1:34 AM
    Yes. That’s what I did. Just pulled master and ran the test.
  • k

    kevins8

    04/06/2022, 1:53 AM
    hmm, what is the latest commit you see when you run git log?
  • p

    Pablo LION

    04/06/2022, 1:54 AM
    commit 553a954bccdf5a8f574b2908f17ccd25fe61cb65 (HEAD -> master, upstream/master, upstream/HEAD, origin/master) Author: Kevin Lin Date: Tue Apr 5 16:01:12 2022 -0700
  • k

    kevins8

    04/06/2022, 1:54 AM
    got it. and what os do you run?
  • p

    Pablo LION

    04/06/2022, 1:54 AM
    git reflog
    Copy code
    553a954bc (HEAD -> master, upstream/master, upstream/HEAD, origin/master) HEAD@{0}: checkout: moving from fix/typo-hierarchy to master
    c23375600 (fix/typo-hierarchy) HEAD@{1}: commit: fix: typo "hierarchy"
    553a954bc (HEAD -> master, upstream/master, upstream/HEAD, origin/master) HEAD@{2}: reset: moving to HEAD
    553a954bc (HEAD -> master, upstream/master, upstream/HEAD, origin/master) HEAD@{3}: reset: moving to HEAD
  • p

    Pablo LION

    04/06/2022, 1:54 AM
    my platform: mac with m1 ..
  • p

    Pablo LION

    04/06/2022, 1:55 AM
    About VSCode
    Copy code
    Version: 1.66.0
    Commit: e18005f0f1b33c29e81d732535d8c0e47cafb0b5
    Date: 2022-03-30T05:49:37.118Z (6 days ago)
    Electron: 17.2.0
    Chromium: 98.0.4758.109
    Node.js: 16.13.0
    V8: 9.8.177.11-electron.0
    OS: Darwin arm64 21.3.0
  • k

    kevins8

    04/06/2022, 1:55 AM
    pulling down a clean copy to see if i can repro
1...969798...108Latest