https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • k

    kevins8

    02/24/2022, 11:52 PM
    i think it should. if you change it, do any tests fail? 😅
  • m

    Maxotronic

    02/26/2022, 7:15 AM
    what's a
    nativeview
    ? Curious if it lets you reproduce the vscode look-and-feel? https://github.com/dendronhq/dendron/blob/dad85f6e1964b5cf21bc0a1007c229c504e17eb5/packages/common-all/src/constants/views.ts#L44
  • k

    kevins8

    02/27/2022, 11:40 PM
    native views are built in vscode views (so regular tree view or customeditor view vs a webview)
  • k

    kevins8

    02/27/2022, 11:41 PM
    more integrated but more limited. eg. see api for vscode treeview: https://code.visualstudio.com/api/extension-guides/tree-view
  • k

    kevins8

    02/27/2022, 11:46 PM
    @User heads up that I compiled a list of frontend projects in this github discussion - https://github.com/dendronhq/dendron/discussions/2491 this came from a conversation I had with @User about Dendron's current frontend backlog if anyone is interested in picking up some frontend work, please post in the gh discussion for more details 🌱
  • s

    SeriousBug

    02/28/2022, 6:31 AM
    Hey, why is there a
    DendronDevConfig
    in
    src/types/workspace.ts
    but also one at
    src/types/configs/dev/dev.ts
    ? Is the former legacy or deprecated?
  • h

    hikchoi

    02/28/2022, 6:43 AM
    the one in
    workspace.ts
    is what's currently in use. we planned to do a migration so
    dev.ts
    was written during the first phase but there's not much point. I will have to clean up the types at some point but until then, use the one in
    workspace.ts
  • m

    Maxotronic

    02/28/2022, 10:25 AM
    Woah fun api, glad I asked
  • s

    SeriousBug

    03/02/2022, 7:58 AM
    Huh wow, never knew about this syntax:
    Copy code
    ts
    let vaults;
    ({ vaults } = await this.handleRemoteRepo(opts));
  • k

    kevins8

    03/02/2022, 2:56 PM
    yeah, its convenient! i quite like modern js syntax around variable assignment/destructuring
  • g

    Gander7

    03/02/2022, 7:04 PM
    destructuring was beautiful when it was added to JS, especially when I was using React
  • m

    Maxotronic

    03/02/2022, 8:53 PM
    I'm having trouble finding the message typedef to simulate an init call (from browser mode).
    init
    is enumerated in
    DMessageEnum
    there's no
    init
    action in
    ideSlice
    or match in
    useVSCodeMessage
    handlers
  • m

    Maxotronic

    03/02/2022, 8:56 PM
    I see [[Lifecycle|dendron://dendron.docs/dendron-engine.ref.engine#lifecycle]] and it looks like
    init
    is not exposed anywhere but in
    setupEngine
    ? https://github.com/dendronhq/dendron/blob/8ac57f1fd50b4fc9f62f9aa0ff8a7093bcfd179f/packages/engine-server/src/enginev2.ts#L260
  • m

    Maxotronic

    03/02/2022, 9:17 PM
    no rush but cc @User - @User mentioned you were touching schemas a bit ago
  • k

    kevins8

    03/02/2022, 9:56 PM
    just an ack that i saw this - in meeting now but will be free in ~45min for a response
  • m

    Maxotronic

    03/02/2022, 10:05 PM
    no worries, sorry for not surfacing this sooner 😖
  • k

    kevins8

    03/02/2022, 11:03 PM
    you can use something like the following to do the sync
    Copy code
    js
    id = "9eae08fb-5e3f-4a7e-a989-3f206825d490";
    window.postMessage({
      type: "onDidChangeActiveTextEditor",
      data: { note: { id }, sync: true },
      source: "vscode",
    });
  • k

    kevins8

    03/02/2022, 11:04 PM
    notice the main diff from the example is
    sync: true
    , this tells the view to do a full sync with the engine instead of displaying the passed in note
  • t

    TomDuffield

    03/03/2022, 11:48 PM
    for v2 pods, are we planning to support plugin style or are we limiting it to core? I've got a v1 confluence export pod kinda working, and trying to figure out what I should be doing to support v2
  • k

    kevins8

    03/04/2022, 12:03 AM
    we are absolutely going to support plugins. we're migrating things over slowly to make sure theres a stable api to develop against. if you have any feedback from developing the v1 pod, would love to hear it 🙂
  • t

    TomDuffield

    03/04/2022, 12:12 AM
    Biggest blocker/road bump I'm hitting right now is that while Confluence will accept HTML, it's somewhat picky (e.g., it won't allow links to no where). So I'm having to kinda tune the rehype parser to fake things out. Another "issue" (along those same lines) is that Confluence has its own macros for certain things like code fences. While it will respect the default remark output, I'm currently trying to figure out if I can short-circuit that in some way so I don't have to decompose that output with unist.
    • 1
    • 1
  • t

    TomDuffield

    03/04/2022, 12:55 AM
    Is there some function I can use to get a note by ID? I see how to get it by path and fname, but not ID.
  • m

    Maxotronic

    03/04/2022, 12:56 AM
    @User should the note hierarchy input for the schema validator have autocomplete? I imagine the lookup command palette autocomplete is straightforward to access?
  • s

    SeriousBug

    03/04/2022, 12:58 AM
    engine.notes[id]
    is the way to go for that
  • m

    Maxotronic

    03/04/2022, 1:43 AM
    are schema templates already validated at any point? should they be?
  • m

    Maxotronic

    03/04/2022, 2:17 AM
    I'd like to watch
    common-all
    and my dendron-plugin-view at the same time. When I run
    ./bootstrap/scripts/watch.sh
    and
    dendron-plugin-views/$ yarn start
    , though, I get this error:
    Copy code
    ../common-all/lib/dnode.js
    Module not found: Can't resolve 'console' in 'dendron/packages/common-all/lib'
  • m

    Maxotronic

    03/04/2022, 2:18 AM
    you can repro by checking out
    enhance/schema-page
    and running
    packages/dendron-plugin-views/$ env REACT_APP_VIEW_NAME=DendronSchemaPageView yarn start
    with
    ./bootstrap/scripts/watch.sh
  • k

    kevins8

    03/04/2022, 2:48 AM
    https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/commands/NoteLookupCommand.ts#L167:L167 for autocomplete
  • k

    kevins8

    03/04/2022, 2:49 AM
    what do you mean by validating schema templates? in the sense that they are a valid markdown file?
  • k

    kevins8

    03/04/2022, 2:53 AM
    it looks like you have the following change in common-all +import { debug } from "console"
1...949596...108Latest