https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • f

    foureyedsoul

    02/16/2022, 6:06 PM
    Just FYI: the people (or maybe just single person?) who make Zettlr are looking for input on features for their new Graph View: https://github.com/Zettlr/Zettlr/discussions/3220 This seems like a great chance to nudge things towards interoperability. A lot of students / researchers / etc might use Zettlr along with Dendron. (I use Dendron far more than Zettlr, so I don't know what features others might want… but I'll mention this in the academia channel, too.)
  • f

    fudo

    02/22/2022, 8:44 AM
    Question based on this issue https://github.com/dendronhq/dendron/issues/2301 does Dendron mess with the copy event in any way? since the source is not html encoded, but what ends in the Clipboard is so somewhere in between it gets html encoded.
  • s

    SeriousBug

    02/22/2022, 8:47 AM
    Dendron does modify what's copied into the clipboard, this is needed to avoid copying the background along with everything else I believe. The relevant code is here: https://github.com/dendronhq/dendron/blob/master/packages/common-server/src/etc.ts#L106
  • f

    fudo

    02/22/2022, 8:59 AM
    Thanks I will check it out and try to fix the issue
  • f

    fudo

    02/22/2022, 10:53 AM
    Okay I just had a freakout moment, following the Quickstart (https://docs.dendron.so/notes/sPDJcZPRfXhKwnmnh9Pea/) and executing the watch script froze my Macbook for a sec, looking further into it the Watch script consumed a loot of my ram
  • f

    fudo

    02/22/2022, 12:43 PM
    Question: If I only want to test something that is in
    common-server
    ? since the watch all freezes my MacBook, are their other options I could use?
  • j

    Joshi

    02/22/2022, 1:32 PM
    You can try package build by : 1. In terminal, go to
    ~\dendron\packages\common-server
    2. run`yarn build` to build only common-server.
  • m

    Maxotronic

    02/23/2022, 12:14 AM
    whats the difference between
    source
    and
    webpack
    in [[Run|pkg.plugin-core.dev.run]]?
  • k

    kevins8

    02/23/2022, 12:17 AM
    so you should almost always be using from source
  • k

    kevins8

    02/23/2022, 12:17 AM
    running from webpack is used when debugging packaging issues
  • k

    kevins8

    02/23/2022, 12:18 AM
    we bundle dendron and all dependencies using webpack which sometimes will result in package specific issues. running from webpack lets you debug that. you should be using the source option
  • f

    fudo

    02/23/2022, 10:31 AM
    @User And Pr is open -> https://github.com/dendronhq/dendron/pull/2471
  • k

    kevins8

    02/23/2022, 3:33 PM
    thanks, will take a look!
  • b

    benhsm | Jack of N trades

    02/23/2022, 4:44 PM
    Having some trouble manual testing the CLI. Getting the following output
    Copy code
    ================================================
    config is out of date.
    ------------------------------------------------
    current client version:            ✅ 0.81.0
    current config version:            ❎ 4
    minimum compatible config version:    5
    ------------------------------------------------
    Please make sure dendron.yml is up to date by running the following: 
     dendron dev run_migration --migrationVersion=0.55.2
    When I run the suggested command, I get
    Migration succeeded.
    , but the other output doesn't change
  • b

    benhsm | Jack of N trades

    02/23/2022, 4:48 PM
    I can see that the values in dendron.yml have changed - should I just up the version number?
  • b

    benhsm | Jack of N trades

    02/23/2022, 4:48 PM
    ok, did that and I'm up and running, going to assume that was the thing to do
  • b

    benhsm | Jack of N trades

    02/23/2022, 5:17 PM
    Looking at
    NoteUtils
    , I'm not sure what to use to tests for the existence of a note in a particular vault
  • b

    benhsm | Jack of N trades

    02/23/2022, 5:17 PM
    is there a preferred way to do this?
  • k

    kevins8

    02/23/2022, 5:29 PM
    can you rebase from master and see if you still get this?
    Copy code
    git fetch
    git rebase master
    yarn setup
  • b

    benhsm | Jack of N trades

    02/23/2022, 5:43 PM
    yes, I still am, but my fork isn't up to date with upstream
  • k

    kevins8

    02/23/2022, 6:02 PM
    ah, got it. can you sync? this should be fixed in latest master
  • b

    benhsm | Jack of N trades

    02/23/2022, 6:14 PM
    I've done something strange with my local repository and my remote branch, but I'll get back to you on this once I've finished reading the pro git book and sorted things out
  • b

    benhsm | Jack of N trades

    02/23/2022, 6:26 PM
    Ok, unless I've misunderstood something about what git is doing, I can confirm this is fixed in latest master
  • b

    benhsm | Jack of N trades

    02/23/2022, 6:30 PM
    still trying to figure this out - I realized that my implementation of
    note move
    will silently clobber existing notes with
    destFname
    , and I intend for it to throw an error if
    destFname
    already exists in
    destVaultName
  • f

    fudo

    02/24/2022, 3:15 PM
    yay my first real code contribution to Dendron was merged xD
  • s

    ScriptAutomate

    02/24/2022, 3:22 PM
    > Pins shiny Horticulturalist badge Welcome to the club! 🌱
  • f

    fudo

    02/24/2022, 3:24 PM
    Thanks, I mean it is one think to write
    RFC's
    xD but I`m happy that I finaly got a better luck at the codebase
  • k

    kevins8

    02/24/2022, 3:31 PM
    kudos for tackling the webview portion of the codebase. that one involves some extra steps!
  • f

    fudo

    02/24/2022, 3:33 PM
    honestly after copying the needed script tag into a mostly blank html file with some Code blocks for with the needed chars to test it was pretty easy and more like finding someone that wanted to do the same / similar thing xD
  • n

    Nidoling

    02/24/2022, 11:34 PM
    Regarding https://github.com/dendronhq/dendron/blob/8ac57f1fd50b4fc9f62f9aa0ff8a7093bcfd179f/packages/common-all/src/vault.ts#L106, is it safe to change to exact match? I'm testing with the test-workspace and i notice theres a bug where if the normPath = "vault1", it will return true if there's another vault called "vault"
1...939495...108Latest