going to bed now but let me know if this works. if not, post logs and we can debug. it clean fails, a fresh clone should work

got it

how are the various versions of code separated? (e.g.

testUtilsv2.ts

and

testUtilsV3

) just evolving over time? might be worth consolidating everything some day 😄 they are a bit confusing.

Yes, yes and yes xD I'm with you on this one. That all should be consolidated into One

testUtils

.

Might not be that simple, as having everything and their legacy counterparts in one location could be even more confusing 😄 gonna need some work.

It would be nice if we can survey all the different versions and make task items to slowly move things over.

Well I meant more like only one testUtils in total without different versions maybe adding depracated flags to it and a since tag to make it easier understood what exists since which version

yeah. I'm sure Kevin has plans for this. I'm down to help when the time comes.

@User @User yeah, the various versions are artifacts from earlier days when we were iterating the core apis daily. now that things are more stable, i'm starting to consolidate it all. tldr, we're going to remove the

vX

suffix and consolidate on a single version. for now, use the latest version number and if you need functionality from an old version, let me know or feel free to move it over to the latest version

I've having a bit of trouble getting the integration test to run locally, the command returns

undefined

despite me trying a few different options. Not sure how many things need to be initialized before I can get a response out of a

Command.run()

, including if I just return a

hello world

string in the very first line of an

execute

. https://a.cl.ly/mXu1v6zK I think I might be missing something basic, any pointers are appreciated. (Isolated my change into this commit - conceptually I think this is what we need, but it doesn't pass when it runs: https://github.com/dendronhq/dendron/pull/512/commits/7ad6525dda669147536b72604323db64e097cb38 )

when you say trouble with running locally, do you mean you got the test to run but its not giving the right result? (eg. are you able to run the other integration tests)

the reason your tests are not passing is because you don't have a note open (I think you put a check to throw an error if no note is open 🙂 )

you can open a note before the tests runs with the following code

ts
      onInit: async ({engine}) => {
          ...
          const note = _.values(engine.notes)[0]
          await utils.VSCodeUtils.openNote(note)
          ...
      }

also you can always set breakpoints inside the plugin. see debug docs here: https://dendron.so/notes/b239c77e-52f2-4cc3-8390-69e0bc776a72.html#breakpoints

Ah yea I should have clarified - the suite is working as it should, it was my test that was the issue 😅

That was it exactly, I was moving quickly and kept that section from the command I based my command off of without checking where in the command lifecycle that

sanityCheck

gets called. I thought I had messed up my setup because I was never reaching the breakpoints I set, but that's because I put them inside

execute

, which never had a chance to run 🙂

Thank you for patiently explaining this + the generous code snippet! The tests are passing now 🙂

no problem. just merged! this will go out in next weeks release!

also, congrats on becoming a

@Horticulturalist

🥳

got it 👍

@User Couldn't sleep so I figured I would wrap this up tonight 😄 https://github.com/dendronhq/dendron/pull/517

with the new update I cannot open file links. Any body with the same problem?

@User for me, everything works fine

@User what command do you use for opening links?

for me editor.action.openLink is not working

It seems your case is a bit different than I thought. I just click on a link and it works 😄

yeah I use the keyboard. With the mouse the link works

hmm, its working for me. dendron doesn't do anything with the built in open link command. do you know if you installed any other extensions that could be interferring?

after trying to open a link with the command, I get an error

haha, whatever helps you sleep at night! will look at this today!