https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • h

    hikchoi

    02/27/2021, 12:38 PM
    do you mean to access this page? https://accounts.dendron.so/account/subscribe
  • u

    user

    02/27/2021, 12:39 PM
    yes. i ultimately got to it via inspect element. but just wanted to make sure whether this is an issue being faced by anyone else
  • h

    hikchoi

    02/27/2021, 12:40 PM
    interesting... the link isn't clickable on the rendered reference but if you click
    go to text ->
    it will get you to the actual page and let you click on the link
  • h

    hikchoi

    02/27/2021, 12:41 PM
    and I think it's just the financial contribution page as well. other references seem to let you click on the links.
  • u

    user

    02/27/2021, 12:42 PM
    yes. also looked into the md file to see whether anything is broken on that specific link or not, but nope. everything seems fine
  • h

    hikchoi

    02/27/2021, 12:44 PM
    Would greatly appreciate it if you can open an issue for this : https://github.com/dendronhq/dendron/issues/new?assignees=&labels=&template=feature_request.md&title= Otherwise, I can do that once I manage to finish my chores and sit down in front of my computer πŸ˜…
  • u

    user

    02/27/2021, 12:45 PM
    sure. i'll do it. just wanted to confirm since this is a weird issue imo
  • h

    hikchoi

    02/27/2021, 12:46 PM
    Thanks a lot πŸ™ I have yet to look into the publishing side of Dendron but I'm sure Kevin will come and save the day soon
  • u

    user

    02/27/2021, 12:48 PM
    @User submitting it here: https://github.com/dendronhq/dendron-site/issues/new if that's fine as it is related to site
  • h

    hikchoi

    02/27/2021, 12:50 PM
    I'm thinking it would be more visible on the main repo but you are right, it's a dendron-site issue.
  • h

    hikchoi

    02/27/2021, 12:50 PM
    we can always open another one in a suitable place once we figure out the root of it πŸ˜„
  • u

    user

    02/27/2021, 12:51 PM
    right. opening in main repo then thanks
  • u

    user

    02/27/2021, 12:58 PM
    done https://github.com/dendronhq/dendron/issues/511
  • k

    kevins8

    02/27/2021, 2:42 PM
    thanks for opening the issue. responded in the link - currently, that's because of the way we render refs with divs and css. we'll be switching over to an iframe based approach that will make this work in the future!
  • u

    user

    02/27/2021, 2:43 PM
    oh got it. thanks for the prompt reply
  • h

    hikchoi

    02/27/2021, 3:04 PM
    @User I saw your ping on github and was gonna work on it today but I was busier than I thought πŸ˜… hectic week for me.
  • k

    kevins8

    02/27/2021, 3:49 PM
    no worries. we’ll always have issues lying around so whenever you feel you have time 😁
  • c

    cameron

    02/28/2021, 10:53 PM
    First VSCode extension / Dendron PR πŸ™‚ https://a.cl.ly/9Zu8yXgr (Dendron PR #512)
  • k

    kevins8

    03/01/2021, 12:53 AM
    awesome, thats some quick turnaround πŸ™‚ left a comment in the PR
  • c

    cameron

    03/01/2021, 4:33 AM
    Yay thanks! Lots of good up to date docs to build on. Regarding testing - the command makes an HTTP request. Should the test actually make a live network request to get the OG data or should that be mocked?
  • h

    hikchoi

    03/01/2021, 4:35 AM
    πŸ‘€ this looks great!
  • k

    kevins8

    03/01/2021, 5:12 AM
    you can use β€œsinon” to mock that
  • k

    kevins8

    03/01/2021, 5:12 AM
    we already import it. you can search for it in the code
  • k

    kevins8

    03/01/2021, 5:13 AM
    https://sinonjs.org/
  • h

    hikchoi

    03/01/2021, 5:14 AM
    @User fyi, looking into https://github.com/dendronhq/dendron/issues/505 today.
  • k

    kevins8

    03/01/2021, 5:31 AM
    awesome, i've set the status to wip πŸ™‚
  • h

    hikchoi

    03/01/2021, 5:35 AM
    hmm..
    yarn bootstrap:build
    is failing somehow.
  • h

    hikchoi

    03/01/2021, 5:39 AM
    I'm running
    npm install
    yarn bootstrap:bootstrap
    yarn bootstrap:build
    on after pulling the upstream master to my fork and it fails on the build πŸ€”
  • k

    kevins8

    03/01/2021, 5:42 AM
    can you try running
    ./bootstrap/scripts/cleanup.sh
    before running install?
  • h

    hikchoi

    03/01/2021, 5:42 AM
    will do
1...515253...108Latest