https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • k
    yep. that will be the yarn
  • k
    you can grep for 
    react-sortable
    in 
    dendron-next-server
    . there shouldn't be any references to it at this point
  • t
    There was (some nextjs cache stuff), but i've deleted those and running the bootstrap script again now... ⏳ .... huh. same error.. hmm
  • t
    Copy code
    % grep -lir "react-sortable" packages/dendron-next-server
packages/dendron-next-server/node_modules/antd/package.json
packages/dendron-next-server/.next/cache/next-babel-loader/55056191f2258c27cf3c8095cf9e7d22.json
packages/dendron-next-server/.next/cache/next-babel-loader/4cbf256cd7b9d483a5e59f65d58392ad.json
packages/dendron-next-server/pages/_app.tsx
    Antd uses it.
  • t
    Perhaps that means we should have it as a peer dependency of antd.
  • t
    The error itself is kind of interesting: 
    Can't resolve 'react-sortable-tree/style.css' in '/home/tyler/Projects/OSS-Dendron/packages/dendron-next-server/pages'
    particularly the "/pages" bit, but perhaps that's just how next spits out dependencies.
  • k
    that is not used anymore so you can go ahead and remove it
  • t
    for clairty, what is 
    it
    ? antd? the page? i removed the 
    .next/cache
    dir before i ran the bootstrap script before.
  • t
    Oh
  • t
    The line in 
    _app.tsx
    , i see
  • t
    new error ⚠️ looks like TS implicit-any / missing type declaration issues.
  • k
    hmm, and you're working from this commit: 1f6ed7e1?
  • t
    Copy code
    % git log                                                
commit ee45b535514c67aae225882809986dc56a65771e (HEAD -> master, tag: v0.15.0, origin/master, origin/HEAD)
Author: kevinslin <kevin@thence.io>
Date:   Sun Nov 8 16:44:45 2020 -0800

    chore(release): publish

commit b15de5d857cb6c99549c1107143c2f43a21f5d0d
Author: kevinslin <kevin@thence.io>
Date:   Sun Nov 8 16:42:21 2020 -0800

    tiny(pods): reload index after import pod
  • t
    hmm odd.
  • t
    looks like there was a commit (well, a push) between a few moments ago and now
  • k
    i might have not pushed it last night
  • k
    that being said, the only diff is the removal of the react-tree line so it wouldn't fix the dendron-cli issues
  • t
    regardless, did a hard reset to HEAD and giving it another go
  • k
    👍
  • t
    ❌ didn't seem to fix my dendron-cli woes, as expected.
  • k
    i remember @User also ran into compiler issues back in the day and was able to move past them by invoking a series of incantations
  • k
    oh, you know what
  • k
    i was optimizing the build script yesterday
  • t
    . 🕯 🕯 🕯 ts gods 🕯 npm 🕯 js 🕯 node modules 🕯 yarn 🕯 🕯
  • k
    lol
  • k
    Copy code
    npx lerna run build --scope @dendronhq/common-all
npx lerna run build --scope @dendronhq/common-server
npx lerna run build --scope @dendronhq/engine-server
npx lerna run build --scope @dendronhq/dendron-cli
npx lerna run build --scope @dendronhq/pods-core
npx lerna run build --scope @dendronhq/seeds-core
npx lerna run build --scope @dendronhq/lsp-server
npx lerna run build --scope @dendronhq/plugin-core
npx lerna run build --scope @dendronhq/api-server
npx lerna run build --scope @dendronhq/dendron-next-server
npx lerna run build --scope @dendronhq/common-test-utils
  • k
    use that in 
    dendron/bootstrap/scripts/build.sh
  • t
    well that seems to have done the trick. made it through bootstrapping.
  • t
    ✨ we in business.
  • t
    thanks for the help. seems like 
    dendron/bootstrap/scripts/build.sh
    was the only thing really in my way after getting up-to-date with your HEAD.
1...222324...108Latest