https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • b

    boxian

    11/03/2020, 8:32 PM
    Will next.js require JavaScript? I know my work computer doesnโ€™t have it or limits it somehow, and VS Code being portable is a big thing for my use case
  • k

    kevins8

    11/03/2020, 8:33 PM
    next.js requires a js runtime but it makes use of the node runtime that comes with VSCode ๐Ÿ™‚
  • b

    boxian

    11/03/2020, 8:37 PM
    Sweet thank you!
  • k

    kevins8

    11/03/2020, 8:38 PM
    np! dendron is moving in the direction of being more portable across more places so if we ever do something that runs counter to that, do let me know ๐Ÿ˜…
  • b

    boxian

    11/03/2020, 8:40 PM
    Love it; thereโ€™s a lot to admire in your design ethos, thanks so much!
  • t

    tfer

    11/04/2020, 2:24 PM
    Video Error in MPE: What I'm seeing:
  • t

    tfer

    11/04/2020, 2:48 PM
    This is from the dendron.install.md file, you can search for "youtube" and see the same image, except the for the file: dendron.topic.publishing.quickstart.md. Comparing them I think I see what is going on. The "working" example is an inline html link to its video with a still image to be shown before playing, the other youtube videos are specified via markdown with no such still image specified. Whatever MPE is using as its rendering-browser is not capable of playing video, and as these videos have no still image, this pops up! I expect if you took away the still image from any of the other video links, you'd get this "apparent" error too.
  • k

    kevins8

    11/04/2020, 2:58 PM
    @User i've seen this issue as well. i don't remember if this was a mpe issue or a vscode webview issue but I remember it being one of those two. mpe uses markdown-it to render html
  • t

    tfer

    11/04/2020, 3:19 PM
    If webview is what vscode uses to render the html MPE generates, then this has to do with webviews inability to play video, e.g. if you click a video in MPE, it opens that video in your system default browser. As the other videos in the dendron notes' videos are hidden behind "still" this isn't apparent there.
  • k

    kevins8

    11/04/2020, 4:42 PM
    i know webview also has some restrictions on certain script executions. don't remember if similar restrictions apply for iframes (i think they do)
  • k

    kevins8

    11/04/2020, 4:43 PM
    fun code updates: with the server migration behind us, I took yesterday to clean up the code base. ended up cutting ~8k lines of code. goal was to bring it under 100k lines of code but I guess that will be for another day ๐Ÿ˜…
  • k

    kevins8

    11/04/2020, 4:43 PM
    - before cleanup
    Copy code
    -------------------------------------------------------------------------------
    Language                     files          blank        comment           code
    -------------------------------------------------------------------------------
    JSON                            73              6              0          72744
    TypeScript                     246           3089           3089          31790
    Markdown                        50           4682              0           5947
    JavaScript                      16            168             76           1349
    Bourne Shell                    23             40              9            179
    YAML                            13              3              3            158
    CSS                              2             17             32             72
    HTML                             1              0              0             14
    SVG                              1              0              0             12
    -------------------------------------------------------------------------------
    SUM:                           425           8005           3209         112265
    -------------------------------------------------------------------------------
  • k

    kevins8

    11/04/2020, 4:43 PM
    - after cleanup
    Copy code
    -------------------------------------------------------------------------------
    Language                     files          blank        comment           code
    -------------------------------------------------------------------------------
    JSON                            73              6              0          72745
    TypeScript                     224           2343           1810          24352
    Markdown                        34           4772              0           5974
    JavaScript                      16            168             76           1349
    Bourne Shell                    24             40              9            181
    YAML                             6              3              3             78
    CSS                              2             17             32             72
    HTML                             1              0              0             14
    SVG                              1              0              0             12
    -------------------------------------------------------------------------------
    SUM:                           381           7349           1930         104777
    -------------------------------------------------------------------------------
  • t

    tfer

    11/04/2020, 5:02 PM
    Webview can't handle .svg images either. Converted to .png 's but still no joy, white version with an alpha channel is invisible, gray version the same for some reason. Might want to have MPE default to a .png version of any .svg for rendering
  • k

    kevins8

    11/04/2020, 6:13 PM
    @User Added some descriptions to frontend tasks. You can find them here: - https://github.com/dendronhq/dendron/labels/area.ui Note that the above link filters for all issues related to UI. In the future, we'll have an RSS feed per area so that folks can subscribe to areas that they are interested in! I would recommend starting with https://github.com/dendronhq/dendron/issues/327 since it's the most fleshed out in terms of documentation and requirements ๐Ÿ™‚
  • t

    tsnieman

    11/05/2020, 1:23 AM
    Thanks for the ping. I'm super familiar with Formik (I was actually working on a form with Formik when you pinged me on this today), so this seems up my alley. Time over the next few days is a little limited, but gonna try to get the serve up-and-running and such before EOW.
  • k

    kevins8

    11/05/2020, 1:24 AM
    haha, must be a sign :) sounds good, no rush and post if you run into anything!
  • t

    tfer

    11/05/2020, 2:54 AM
    I've made some documentation changes to my fork of https://github.com/dendronhq/dendron-template, what do I need to summit a PR? Do I need added as a contributor?
  • k

    kevins8

    11/05/2020, 4:41 AM
    @User a pull request would be great. you shouldn't need anything to submit a PR
  • k

    kevins8

    11/09/2020, 6:40 PM
    heads up that the next version of vscode (1.52) will make it possible hide snippets ๐Ÿฅณ this means we can have live completion turned on without having to turn off snippets (otherwise, the builtin markdown snippets get too annoying) https://github.com/microsoft/vscode/issues/10565#issuecomment-721832613
  • k

    kevins8

    11/09/2020, 6:43 PM
    @User did you have a chance to look at the nextjs stuff this weekend? no worries if not, just want to make sure there weren't any blockers when trying to get things setup
  • t

    tsnieman

    11/10/2020, 1:48 AM
    @User Doing it now ๐Ÿ™‚ Had a busy weekend.
  • t

    tsnieman

    11/10/2020, 1:48 AM
    The bootstrapping script seems to be giving me grief right now
  • k

    kevins8

    11/10/2020, 1:50 AM
    oh, that was a bad package from a previous dependency
  • k

    kevins8

    11/10/2020, 1:50 AM
    if you pull the latest, it should be gone now
  • t

    tsnieman

    11/10/2020, 1:50 AM
    I just cloned this a few minutes ago.
  • k

    kevins8

    11/10/2020, 1:51 AM
    hmm, it might be because of the lock file
  • t

    tsnieman

    11/10/2020, 1:52 AM
    That's my suspicion as well.
  • k

    kevins8

    11/10/2020, 1:53 AM
    cd packages/dendron-next-server
    and
    rm yarn.lock rm package-lock.json
  • t

    tsnieman

    11/10/2020, 1:53 AM
    Can do. (i'd imagine we only want one of those files in general, as well)
1...212223...108Latest