Dendron #dev

britt

10/26/2020, 11:19 PM

This is on

master

... I traced it to

fs-extras

->`jsonfile` and then looked at references. I didn't check which one, but it's whichever one is called on

init

😄

britt

10/26/2020, 11:22 PM

Also, underwhelmingly, this has nothing to do with links mysteriously not being registered today (for me). What's the highest level that gets touched from the extension? Is that rendered in plugin-core as a response to the language-server? (I'm guessing I need to check both plugin and server)

kevins8

10/26/2020, 11:23 PM

remind me what the links issue is again?

britt

10/26/2020, 11:26 PM

Oh, on master over here backlinks aren't being recognized, nor is intellisense returning results.

kevins8

10/26/2020, 11:26 PM

are you running dendron with extensions disabled?

britt

10/26/2020, 11:26 PM

Aye.

kevins8

10/26/2020, 11:27 PM

so dendron has 2 ways of launching when developing

kevins8

10/26/2020, 11:27 PM

Copy code

{
      "name": "Run Extension -- disable extensions",
      "type": "extensionHost",
      "request": "launch",
      "runtimeExecutable": "${execPath}",
      "args": [
        "--disable-extensions",
        "--extensionDevelopmentPath=${workspaceFolder}"
      ],
      "outFiles": ["${workspaceFolder:plugin-core}/out/**/*.js"],
      "env": {
        "STAGE": "dev",
        "VSCODE_DEBUGGING_EXTENSION": "dendron",
        "LOG_LEVEL": "info"
      }
    },
    {
      "name": "Run Extension",
      "type": "extensionHost",
      "request": "launch",
      "runtimeExecutable": "${execPath}",
      "args": [
        "--extensionDevelopmentPath=${workspaceFolder}"
      ],
      "outFiles": ["${workspaceFolder:plugin-core}/out/**/*.js"],
      "env": {
        "STAGE": "dev",
        "VSCODE_DEBUGGING_EXTENSION": "dendron",
        "LOG_LEVEL": "info"
      }
    },

kevins8

10/26/2020, 11:27 PM

if you run in the former mode, it will turn off all other extensions

kevins8

10/26/2020, 11:27 PM

currently dendron-markdown-notes is responsible for intellisense and backlinks...

britt

10/26/2020, 11:27 PM

Yes, I'm running in the former.

kevins8

10/26/2020, 11:28 PM

if you run the former, it will disable dendron-markdown notes 😅

kevins8

10/26/2020, 11:29 PM

For development, I uninstall Dendron and manually install Dendron Markdown Notes and Dendron Markdown Preview. Then I run with the latter config when I want to test Dendron with intellisense or backlinks

kevins8

10/26/2020, 11:29 PM

will update the dev setup docs

britt

10/26/2020, 11:30 PM

1. That didn't occur to me and I assumed --disable extensions included the minimal subset like markdown-notes. 🙈

britt

10/26/2020, 11:31 PM

2. It's still broken, but let me dig in a bit further.

kevins8

10/26/2020, 11:32 PM

you mean the latter configuration of running dendron? if you have dendron installed, the installed dendron can interfere with the dendron your debugging. this is why I use a separate vscode version (eg. normal vscode) to work on dendron

britt

10/26/2020, 11:33 PM

Oh, that's an interesting solution. I had just uninstalled dendron proper when working on dendron.

britt

10/26/2020, 11:34 PM

I bumped my head on the multiple instances issue before and started doing ^^^

kevins8

10/26/2020, 11:35 PM

yeah. will updated the setup docs. hopefully you'll be the last dev to bump into this particular issue 😅

britt

10/26/2020, 11:36 PM

Oh I see,

dendron-markdown-notes

is packed, not recommended, which makes sense.

kevins8

10/26/2020, 11:42 PM

yep. in the future, we're planning on writing our own implementation of markdown-notes inside dendron but for now, we're relying on the forked version for backlinks and a few other features

britt

10/26/2020, 11:52 PM

I wonder if something like

key: "dendron.initWS-dev",

constants.ts

would be a correct way of handling this, or does it go deeper?

kevins8

10/26/2020, 11:55 PM

you mean to setup a dendron workspace environment? that's not a bad idea. dendron plugin checks if its activated here: https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/workspace.ts#L154:L154

kevins8

10/26/2020, 11:56 PM

i don't think you would even need a constant

kevins8

10/26/2020, 11:56 PM

vscode sets a special DEVELOPMENT flag when running from debugger

kevins8

10/26/2020, 11:57 PM

also, we have this: https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/constants.ts#L521:L521

britt

10/26/2020, 11:57 PM

Yes, and I hadn't thought about implementation yet. The clash is registering commands to vscode.

kevins8

10/26/2020, 11:58 PM

yeah, that's going to be a thing. i think its possible to set the extension dir when running from debugger

britt

10/26/2020, 11:59 PM

Not sure if just fixing that will expose other issues, but they could be assigned something like

WSINIT.{version|sha}