https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • b

    britt

    10/26/2020, 9:42 PM
    The developer monorepo.
  • k

    kevins8

    10/26/2020, 9:43 PM
    got it. yes, i'm all for that
  • b

    britt

    10/26/2020, 9:43 PM
    Would allow minimal (functional) workspace settings and then devs to theme locally to their needs.
  • k

    kevins8

    10/26/2020, 9:43 PM
    🚢
  • b

    britt

    10/26/2020, 9:44 PM
    🤙 Rad, will patch and update docs.
  • b

    britt

    10/26/2020, 9:44 PM
    🦇
  • k

    kevins8

    10/26/2020, 9:44 PM
    👍
  • b

    britt

    10/26/2020, 9:52 PM
    p.s. Are you getting this on your end?
  • b

    britt

    10/26/2020, 9:52 PM
    https://github.com/dendronhq/dendron/issues/304
  • k

    kevins8

    10/26/2020, 9:53 PM
    hmm, looks like there's malformed json in the workspace?
  • b

    britt

    10/26/2020, 9:54 PM
    That's what I thought but linter isn't throwing and a quick visual inspection looked good.
  • b

    britt

    10/26/2020, 9:54 PM
    Wanted to make sure it wasn't just me before diving deeper.
  • k

    kevins8

    10/26/2020, 9:55 PM
    hmm, i'm not seeing
  • k

    kevins8

    10/26/2020, 9:55 PM
    what happens when you copy the code-workspace file from another workspace into the problematic one and reload the window?
  • b

    britt

    10/26/2020, 10:51 PM
    Ah, I see.
  • b

    britt

    10/26/2020, 10:51 PM
    Sheesh.
  • b

    britt

    10/26/2020, 10:55 PM
    vscode follows json spec + json w/ comments (jsonc), which I don't even see a formal spec for.
  • b

    britt

    10/26/2020, 10:56 PM
    fs-extra
    reads json via
    jsonfile
    which is actual json, so workspace configs can be valid in vscode and invalid in dendron.
  • k

    kevins8

    10/26/2020, 10:57 PM
    yep, that bit me a few times
  • k

    kevins8

    10/26/2020, 10:57 PM
    thats why we have this https://github.com/dendronhq/dendron/blob/master/packages/common-server/src/filesv2.ts#L121:L121
  • b

    britt

    10/26/2020, 11:01 PM
    Ah, got it ... but not migrated to it yet, correct?
  • k

    kevins8

    10/26/2020, 11:13 PM
    not everywhere 😅
  • b

    britt

    10/26/2020, 11:14 PM
    🐋
  • b

    britt

    10/26/2020, 11:14 PM
    Updated bug.
  • k

    kevins8

    10/26/2020, 11:15 PM
    do you have the line where this is happening? i'm currently working on fixing upgrade issues right now
  • b

    britt

    10/26/2020, 11:15 PM
    Where fs-extras is called?
  • k

    kevins8

    10/26/2020, 11:16 PM
    a whole bunch of places. did this bug happen in the development version of dendron or the production version?
  • k

    kevins8

    10/26/2020, 11:18 PM
    nvm, think i found it https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/_extension.ts#L49:L49
  • k

    kevins8

    10/26/2020, 11:18 PM
    we read the json correctly when upgrading but don't do it when dumping into logs for debugging
  • k

    kevins8

    10/26/2020, 11:18 PM
    🤦‍♂️
1...161718...108Latest