Reminder: Monday is our community syncup meeting a...
# contributor-sync
s
Reminder: Monday is our community syncup meeting at 9AM PST/12 PM Eastern/6 PM Central Europe. Here is the Microsoft Teams Link to join the meeting.
z
I have to miss this mornings unfortunately
s
@Koorous Vargha maybe keep it async today? We don't have much to discuss. Would love to know about the config overrides that you use though
k
Sure. I've got this PR merged: [controller] Change defaults to production values Working on the next component: [server] Change defaults to production values It's taking more time than I expected as changing the defaults break quite a lot of tests.
s
awesome. Thank you
šŸ‘ 1
k
Did changing the push strategy to n - 1 fix the errors during deployment?
s
Yes, it all worked. In tandem with a few other timeouts, and using node_removable API, we could achieve stable rollouts without disruption in VPJs. https://docs.google.com/document/d/1kmysPVYJRkmhQz4v7mozLU0Sq3j717w3oYbBwpNuJAc/edit?tab=t.0
šŸš€ 2
k
Thanks for providing the detailed configs you used. I'll go over it to see if I've missed anything when changing the defaults in our codebase
@Sergey Makagonov Is whatnot using Helix As A Service (HAAS) or Helix As A Library?
s
as a library I guess. We just use what venice came with
so whatever is on the controller
šŸ‘ 1
Hope it's not an issue?
k
No not really. They're just two separate code paths in the controller and it helps me determine if the library configs needs to be updated too
Because we use HAAS internally
s
got it. Btw, for the PRs that you have - you cover servers and controller. Anything on the router end that may be useful?
k
Possibly. I’m doing it component by component to control the blast radius
Any defaults changed break the tests, so they need to be updated accordingly
s
got it
k
https://github.com/linkedin/venice/pull/2863 is merged now. Will continue with the other components as much as I can this week. Also, a heads up. I will be out the next 2 weeks starting next week. July 4 - July 12 is when LinkedIn will be shutdown for a break, so there will be some spotty responses during that time from the folks at LinkedIn.
šŸ™ 1
Fast client done: github.com/linkedin/venice/pull/2895 Thin client already has the production defaults
gratitude thank you 1
šŸ˜Ž 1