https://twill.io logo
Join Discord
Powered by
# ❓questions
  • s

    Shiftless

    09/02/2021, 10:17 AM
    'bind_exception_handler' => false,
    does not fix it.
  • i

    ifox

    09/02/2021, 10:17 AM
    right
  • i

    ifox

    09/02/2021, 10:18 AM
    thanks for the details, 2.5.1 will be coming up shortly to fix this
  • s

    Shiftless

    09/02/2021, 10:20 AM
    awesome. ty looking forward to the multiple edtior_blocks. 🥳
  • i

    ifox

    09/02/2021, 10:48 AM
    @User I can reproduce, this is affecting users extending Twill's exception handler. Are you calling anything from it in your extended handler?
  • s

    Shiftless

    09/02/2021, 11:13 AM
    @User https://pastebin.com/jvjn6j7W
  • i

    ifox

    09/02/2021, 11:18 AM
    just had a call with @User, we're on it @User
  • i

    Ivan Markov

    09/02/2021, 11:36 AM
    Hi. please tell me how in 'area-17/twill-image' i can display images (in sources) with different Device pixel ratio
  • i

    ifox

    09/02/2021, 11:40 AM
    @User Twill Image is using width descriptors, which is a better approach to let the browser pick the best resolution > Instead of supplying fixed image sizes and densities, the size of each supplied image can be specified by adding a width descriptor along with the size of the image element, allowing the browser to automatically calculate the effective pixel density and choose the best image to download.
  • i

    ifox

    09/02/2021, 11:42 AM
    so the idea is that you should provide the largest width you'd like to support in your preset. So if you were to use a 1500px image at 2x, use a 3000px width in your preset instead, and the browser will pick that one if on a 2x screen if the image intrinsic size is at 1500px.
  • i

    ifox

    09/02/2021, 11:43 AM
    that way a 3x device will also be able to pick from your list of width, instead of forcing a width at each DPR
  • l

    leftblank

    09/02/2021, 1:27 PM
    I'm still seeing some issues in 2.5 with the BelongsTo browser and restoring revisions - i'm no longer getting an error, but old relationships are not being restored in my case
    p
    • 2
    • 19
  • p

    pboivin

    09/02/2021, 1:37 PM
    Hey @leftblank, I'll look into this!
  • l

    leftblank

    09/02/2021, 1:42 PM
    thanks @User 🙂
  • l

    leftblank

    09/02/2021, 1:42 PM
    let me know if you need any more info
  • l

    leftblank

    09/02/2021, 1:42 PM
    might be stuff in my implementation, potentially!
  • i

    ifox

    09/02/2021, 2:07 PM
    @User https://github.com/area17/twill/releases/tag/2.5.1
  • s

    Shiftless

    09/02/2021, 2:07 PM
    i will give it a try and report back to you
  • s

    Shiftless

    09/02/2021, 2:10 PM
    @User looking good. composer update did pass with no errors this time. you guys are awesome.
  • p

    pboivin

    09/02/2021, 2:49 PM
    belongs-to-browser-revisions
  • s

    Shiftless

    09/03/2021, 8:26 AM
    https://github.com/area17/twill/pull/918 does break all of our block_editors. as
    window['{{ config('twill.js_namespace') }}'].STORE.form.availableBlocks
    is undefined when the
    views/partials/form/_block_editor.blade.php:18
    tries to push blocks into it
    window['{{ config('twill.js_namespace') }}'].STORE.form.availableBlocks['{{ $name }}'] = {!! json_encode(array_values($allowedBlocks)) !!}
  • i

    ifox

    09/03/2021, 8:46 AM
    @Shiftless do you have a custom _block_editor view in your project?
  • s

    Shiftless

    09/03/2021, 8:46 AM
    no we do not.
  • i

    ifox

    09/03/2021, 8:49 AM
    ok. anything custom I need to be aware of to reproduce this? did you make sure to update your Twill frontend assets?
  • i

    ifox

    09/03/2021, 9:05 AM
    Did you override Twill's form layout? https://github.com/area17/twill/blob/93e665ef169c6333bff91c5aa7fa64b894baa8d5/views/layouts/form.blade.php#L127
  • s

    Shiftless

    09/03/2021, 9:34 AM
    no we are using the defautl one.
  • i

    ifox

    09/03/2021, 9:38 AM
    try clearing views and caches
  • s

    Shiftless

    09/03/2021, 9:46 AM
    if i change line 127->128 from:
    Copy code
    availableBlocks: {},
    blocks: {},
    to:
    Copy code
    availableBlocks: [],
    blocks: [],
    Everything works just fine.
  • s

    Shiftless

    09/03/2021, 10:03 AM
    i got it working by deleting everything other than the index.php in my public folder.
  • h

    Hữu Hiếu

    09/04/2021, 11:46 AM
    hi, sry my bad english
1...858687...484Latest