https://twill.io logo
Powered by
# ❓questions
  • z
    Hi, everybody. I'm using nestedset to try and get some page hierarchies to work correctly, but am having real trouble getting these values to save to the db. I'm using a single select with a name of 
    parent_id
    and dynamically loading page options into it - which appears to be working fine. As dynamic options didn't seem to be discussed in the single select documentation, I used the same method described for multi-select and that seems to have worked. However, when I select a parent page and click to update, the 
    parent_id
    remains unchanged in the fields array - even though every other field and block is updated. I've verified this by looking at the request data via Telescope, so I'm reasonably sure the updated value is never actually sent to the backend. It retains the value it has when the page originally loads. If I change the select's name to something else (e.g. "`parent`") and submit this, the example "`parent`" value will be successfully submitted in the fields array - though 
    parent_id
    is still present and still retains its originally loaded value. My guess is that something is preventing the 
    parent_id
    value from being updated prior to it being sent out via XHR when the page is updated. I've been combing through the source trying to find out where this XHR request is generated so I can get a clue why this isn't working correctly but I've run out of ideas. I (even looked at the select field using Vuetools, I can see the value updated on the component in realtime), but my Vue knowledge is a bit limited. Is there something I've missed?
  • i
    hi @ZeroGodForce, parent_id is already on the form in the publication sidebar in this case
  • i
    That's why it's not sending yours and still sends it when you change the name of yours
  • i
  • z
    This sidebar?
  • z
    Just tried commenting out my parent select field. No change I'm afraid
  • i
  • i
    If you pass your possible parents to the formData, it will show up
  • i
    I'm realizing now that this is something the NestedModuleController should do on its own cc @pboivin
  • i
    so if you rename your parent key to parents, it should show up
  • z
    Will try it now
  • z
    Okay so that sort of semi-worked. using 
    parents
    made it appear, however I don't think the format I'm sending the data in is correct.
    Copy code
    return [
                'value' => $key,
                'label' => $item
            ];
    and variations thereof doesn't appear to work here. Nor did simply passing a collection of page models. Is there a "correct" format I should be looking for?
  • a
    ok, i'll try it
  • z
    Ta
  • k
    Idk if you need to map items here to create compatible 
    label
    & 
    value
    list. For select fields enough is to provide
    Copy code
    php
protected function formData($request)
{

    return [
        'parent' => app(PageRepository::class)->listAll(),
    ];
}
    This works well in forms.
  • z
    That's what I had originally and it doesn't reveal the parent page dropdown - even using the right 
    parents
    key
  • a
    didn't work, my block layout is:
    Copy code
    <!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
    <meta http-equiv="X-UA-Compatible" content="ie=edge">
    <link rel="stylesheet" href="{{ asset('assets/page/css/styles.css') }}">
    <style>
        html, body {
            height: auto;
        }
    </style>
</head>
<body
    style="
        overflow-x: hidden;
        margin-top: -1px;
        margin-bottom: -1px;
        padding-top: 1px;
        padding-bottom: 1px;
    "
>
    @yield('content')
</body>
</html>
  • a
    the only way to make the iframe 100vh or 100% height is changing the iframe height
  • a
    i didn't find another way around
  • a
    didn't work either
  • h
    @User sorry I mean I set a min height on the block wrapper, not on the block layout.
  • i
  • i
    the parents end up in a regular select field as options, so label/value should work
  • z
    @User @User I figured it out
    Copy code
    $options = Page::all()->map(function ($item, $key) {
            return [
                'id' => $item->id,
                'name' => $item->title
            ];
        });
    it was 
    id
    and 
    name
    rather than 
    label
    and 
    value
  • z
    Ran and checked with the DB and appears to be working as desired. Thanks guys
  • k
    Ok I have searched why is this happening (probably you found it also), but its this util https://github.com/area17/twill/blob/ec21b4b6cbc3813c659c168609fe96a72f181c0d/frontend/js/utils/parentTreeToOptions.js Like u said 
    id
    and 
    name
    are used.
  • z
    So for anyone looking, the full function in 
    Admin/YourModuleController.php
    , it's:
    Copy code
    php
    /**
     * Return a list of possible parent pages
     * 
     * @param $request
     * @return array
     */
    protected function formData($request)
    {
        $options = Page::all()->map(function ($item, $key) {
            return [
                'id' => $item->id,
                'name' => $item->title
            ];
        });

        return [
            'parents' => $options
        ];
    }
  • z
    @User actually I was looking for parentTreeToOptions when I had the idea and just guessed
  • k
    @User should we propose update for this method listAll to return parent specific select option fields?https://github.com/area17/twill/blob/9cf55f2cdf578037dc2baad8ef1c169572414cc8/src/Repositories/ModuleRepository.php#L166
  • a
    you mean the vue component or the block itself?
1...262263264...484Latest