https://twill.io logo
Powered by
# ❓questions
  • a
    can i make a PR for this?😅
  • f
    Hey folks, run into a strange issue related to testing and was wondering if anyone had any bright ideas. I'm writing some simple functional tests to make sure that various pages of a twill-powered site show up as expected. As part of this process I've created a some Laravel model factories for various Twill module models and I'm creating models in my tests - all standard stuff. However I've noticed that generating models using a factory for any models that extend Twills base model are a LOT slower than factories generating 'regular' Eloquent models. Here's an example:
  • f
    Copy code
    /** @test */
    public function testing()
    {
        Demo::factory()
            ->count(8)
            ->state(new Sequence(
                ['title' => 'Article 1'],
                ['title' => 'Article 2'],
                ['title' => 'Article 3'],
                ['title' => 'Article 4'],
                ['title' => 'Article 5'],
                ['title' => 'Article 6'],
                ['title' => 'Article 7'],
                ['title' => 'Article 8'],
            ))
            ->create();
        
        $this->assertTrue(true);
    }
  • f
    In this test I'm creating 8 'regular' models and the test takes 0.139 seconds to run. However in this test:
  • f
    Copy code
    /** @test */
    public function testing()
    {
        Article::factory()
            ->count(8)
            ->state(new Sequence(
                ['title' => 'Article 1'],
                ['title' => 'Article 2'],
                ['title' => 'Article 3'],
                ['title' => 'Article 4'],
                ['title' => 'Article 5'],
                ['title' => 'Article 6'],
                ['title' => 'Article 7'],
                ['title' => 'Article 8']
            ))
            ->create();

        $this->assertTrue(true);
    }
  • f
    I'm creating the same number of Twill models and the test takes 1.442 seconds to run. To make matters worse this time penalty is repeated per test even when using 
    RefreshDatabase
    . These tests are all using a sqlite in-memory DB by the way.
  • f
    Bit stumped by what could be causing this - would welcome any thoughts while I try and debug
  • f
    Quick update: just tried the same test but this time creating the 
    Article
    models via the repository create method:
  • f
    Copy code
    /** @test */
    public function testing()
    {
        collect([
            'Article 1',
            'Article 2',
            'Article 3',
            'Article 4',
            'Article 5',
            'Article 6',
            'Article 7',
            'Article 8'
        ])->each(function($title){
            app(ArticleRepository::class)->create([
                'title' => $title,
                'published' => true,
            ]);
        });
        
        $this->assertTrue(true);
    }
  • f
    This is actually slower still (3.308 seconds) so I'm wondering if there are perhaps model events firing when creating new models (either via a factory or repository) that might be slowing things down?
  • i
    Hi @FourStacks thanks for sharing about this, any chance you could share a small repo for me to quickly reproduce this?
  • f
    Sure thing - I'll whip one up now
  • i
    awesome, that'll be helpful
  • f
    Ahh, ok my bad - tried to reproduce this and couldn't and I just realised the difference was that the models in my project that I was testing implement Laravel Scout via the 
    Searchable
    trait. Once I remove that they run like greased lightning. Just need to add 
    <server name="SCOUT_DRIVER" value="null"/>
    to my phpunit.xml and all is well again. Sorry to have wasted your time @User!
  • i
    no problem, that makes sense, glad you figured it out!
  • a
    hello, the docs says that i can add a note to the checkbox field but it doesnt work
  • a
    i think $note is missing
  • h
    Hey @User that's correct, there is a pr for that https://github.com/area17/twill/pull/1355
  • a
    😅
  • u
    Hi, Currently, is there any view, but the database, to see all slugs created for a specific model and even possibly reactivate an older one?
  • i
    hi @User not at the moment outside of the db
  • u
    hey, thanks @User
  • a
    I need some advice to know if my way of making the pages module is correct since it is my first project in twill I made the pages module that in the form only has the description field and the block editor It's okay like that?
  • a
    my idea is that the user has complete freedom in how they want to build their content
  • i
    for sure. That's perfectly fine. If you need more structured content outside of the block editor you would add more fields there, for example you might not want the hero to be in the block editor if it is required on this page type, but that's really up to you and how much flexibility you want to give to your editors
  • s
    Hello, sorry I didn't reply to this, priorities at work changed. However yes, I copied the blade field but all I get now is a slug field I can manually edit. It doesn't get updated when the title is changed
  • i
    make sure you link the 2 field like they are in the create partial
  • a
    thanks!
  • i
  • s
    I get formatPermalink is not defined
1...249250251...484Latest