Asking because we recently encountered a bug based on our own misunderstanding of the intended order of events around calling

order_shipping

and

shipment

methods. (The

order_shipping

method can update the state of the shipment to

shipped

, but it does so via a direct column update rather than via the statemachine, and so therefore will not invoke state machine callbacks)

Hey Tom, yep, there’s some twisted logic in that part. There’s no active work on this part, despite not being clear it’s not super unstable that needs some priority. If you have any suggestion for something that might be a good trade-off to improve clarity, we will definitely consider changing that.

Got it, thanks! I'll give it some thought - I just didn't want to end up going against something that was already planned.

BTW: can you link where you found those comments, please?

Sure! https://github.com/solidusio/solidus/blob/0d89c89d8b045b4acf1868c420f954a7a20ff4bb/core/app/models/spree/order_shipping.rb#L26 and https://github.com/solidusio/solidus/blob/0d89c89d8b045b4acf1868c420f954a7a20ff4bb/core/spec/models/spree/order_shipping_spec.rb#L180