When reading through some of the solidus code, there seems to be a bit of a confusing relationship between

shipment.ship

and

order_shipping.ship

. It seems like there's some intention to potentially invert the relationship these method calls have with each other. (ie, today,

shipment.ship

invokes

order_shipping.ship_shipment

, and it seems like it might intend to be the other way?)