We have finished up metadata and believe this is a...
# general
f
We have finished up metadata and believe this is a middle ground: • cancancan has been implemented • various resources have been removed (such as Addresses) • we strictly limited the features on users and transactions in the widest possible intepretation including also resources such as RMAs) We would appreaciate a glance of a review to understand if this has a shot or not for not wasting anyone’s time. https://github.com/gms-electronics/solidus/pull/4
👍🏻 1
t
Just tried to review, but the changes in single commits are soo huge that they literaly crashed my browser. Could you please create smaller commits that are self contained (ie. first introduce the actual metadata object, with tests but without using it and then commit by commit introduce it in the models that require it). That way it would be much easier to review and reason about. There is a lot of good information in the PR description, but this information is missing in the commits. Writing smaller atomic commits helps also writing better commit messages, because the context is smaller and better explained that way. This is a great resource I share often. Especially #7 is very important. We also linked some more notes about good git commit messages and why they matter in our
CONTRIBUTION.md
file. https://cbea.ms/git-commit/
f
yes, we can do it, let me talk to mayur to get it done.
Do you want me to send you ram sticks 😉
Hey, we can push the broken down review not before tonight. Meta is already broken down in commits, do you think you can find the time to look at it?