<https://github.com/solidusio/solidus/pull/6090> b...
# general
f
https://github.com/solidusio/solidus/pull/6090 brakes sandbox with subscription.
m
Please write an issue detailing how it "breaks", and what exactly is wrong. I'll look at it, but I'm not willing to first find out what you think my problem is.
An issue means not here, but on Github. You can link it, thank you.
f
@Mayur Shah I am in meetings this morning, could you please outline the issues as detailed as possible to @mamhoff with screenshots, I opened up #317 for that.
@mamhoff do you think it makes sense to make a check also on other core extensions?
m
@mamhoff I have added more details in a comment. Let me know if you need further clarification or additional specifics. https://github.com/solidusio/solidus_subscriptions/issues/317#issuecomment-2626732899
f
@mamhoff the issue has been updated with a more precise description and should contain anything you need. If you have more questions you can tag @Mayur Shah directly
πŸ‘ 1
t
@Fabian V. Thobe @Mayur Shah please stop mentioning voluntary contributors in this community. Open tickets on the appropriate places and wait until someone picks it up. Ideally work on a solution first and wait for a review. These rules are commonly known and additionally manifested in our contribution and community guide lines. Please follow them. Thanks
πŸ‘ 2
f
ok
πŸ‘πŸ» 1
m
PSA It's not hard to block people. That way as a contributor I can at least stop the annoying notifications.
f
Thanks, it was very kind of you to fix it quickly.
πŸ‘πŸ» 1
We will test it and report in the issue.
Sorry, wrong chat, sandbox of subscriptions is still broken
m
Wow. It imagine it would be unpleasant to work with you even if you paid. See. If you want work out of volunteers, communication is key. Be friendly. Be considerate. Double-check what you write is correct. Because if it is not, you have just wasted another person's time. Wasting people's time slowly, but surely erodes the natural helpful disposition of most people. In my testing the sandbox of
solidus_subscriptions
works. 🀑 (Full disclosure, I've offered you paid services but you insisted on estimates and tried to negotiate down to single-digit hours. I'd tolerate that if you were a poor non-profit).
πŸ‘ 1
f
Anything else to add?
@Mayur Shah can you check again?
t
@Fabian V. Thobe would it be possible to use your own messaging app for coordinating your own work? Or at least use a private channel or PMs? We would love to keep the SvN ratio up here. Thanks
f
Sure
πŸ‘πŸ» 1
Thomas, we are reaching an impass with reviews (as we need them for structured data) and meta (as we need them for subscriptions). Do you think there’s a possibility to review them before Friday or should we withdraw the PR from next week on. I just do not realistically see free resources before June / July to make larger fixes to any of the two PR. @Mayur Shah can unsquash reviews to more atomic commits (I see it as a 2.0 though) to make it easier for you to evaluate and we can come in your direction on changes this week, but we do need to have an idea where the train is going.
t
Trying to do my best to squeeze it into my tight client work schedule. Cannot promise anything. Making PRs easy reviewable by making small concise well described commits always helps. The harder it is to understand a change and especially why it has made the larger the chances are that a PR does not get reviewed soonish or at all. So please help us by preparing them very well.
And adding more and more comments on several platforms, issues, etc. just to keep up the pressure does not help as well.
⁉️ 1
f
Ok, I would suggest that we keep reviews outside of solidus for now and focus on meta as that seems to be more prepared to your liking. Is that ok for you?