Party time: The upcoming `SolidusPromotions` gem i...
# general
m
Party time: The upcoming
SolidusPromotions
gem is ready for review here https://github.com/solidusio/solidus/pull/5805 - it's got all the features from SolidusFriendlyPromotions, but would, if the PR is merged, go under the
solidus_promotions
name. It's the culmination of more than a year of work, with help from @tvdeyen, @kennyadsl, @Jared Norman, @Adam Mueller, @elia, and some more people who probably aren't on this Slack. Enjoy testing it!
πŸš€ 13
❀️ 12
πŸŽ‰ 14
k
Thanks again Martin, you are a hero!
πŸ’― 4
☝🏻 1
☝️ 1
m
I rebased the PR on
main
, getting rid of the annoying
unmerged history
. Thanks
git filter-branch
- and thanks to this article: https://manishearth.github.io/blog/2017/03/05/understanding-git-filter-branch/
k
I promise I’ll take a look soon, please give me some time cause it’s huge!
m
No pressure πŸ˜…
Hold off for a bit more, I'm still looking for the holy Grail of git-fu (preserve history and merges, but set main as parent of initial commit of old repo
Ok, I'm keeping it the way it is now. I've tried enough πŸ™‚