The specs on solidus_braintree are deeply red. I'v...
# general
m
The specs on solidus_braintree are deeply red. I've fixed the first error in this PR https://github.com/solidusio/solidus_braintree/pull/155 but there are more errors after that. All I wanted is bump a dependency. https://github.com/solidusio/solidus_braintree/pull/156
All fixed, thanks to @tvdeyen for reviews and support. @kennyadsl we've bumped the
braintree
SDK dependency by a major version. Will try this out tomorrow in our app, if that works all fine this probably deserves a release.
👍 1
It's been running fine for about a day and a half now, I think this can be released
k
I’ll try to take a proper look tomorrow
I think that a patch-level is ok for those changes, WDYT?
m
I would say minor version. There's a few breaking changes in the API of the Braintree gem that the extension does not touch, but I had to adapt how we integrated it a little